Mixing in roles to generated classes

[rabbiveesh]

The Problem

I've been setting up API clients for amazon's advertising APIs, and in the course of doing so, it was most convenient to mix in certain shared behaviors with a role.

The issue that I'm having is that I can't mix in roles nicely to the generated classes. For example:

OpenAPI::Client->with_roles('My::Awesome::Role')->new('path/to/spec.yaml')

Will still return a subclass of OpenAPI::Client, rather than a subclass of the package created by mixing in my role.

The alternative of

OpenAPI::Client->new('path/to/spec.yaml')->with_roles('My::Awesome::Role')

works, except that the behavior is surprising, b/c the role never gets instantiated, so the defaults for fields in the role are not set.

For reference, I use Moo::Role to create attributes (access to redis for storing access tokens, for example).

Ideas

Either the constructor for OpenAPI::Client should use a dynamic classname when generating the child class on lines 71-74, or there should be an extra argument for putting more stuff into the generated class.
Or perhaps give access to the generated class before instantiating it?

Thanks for this wonderful module!

[jhthorsen]

Thanks for the feedback!

I'm sorry, but I don't see any issue with doing "with_roles" after the class has been generated. The documentation states that a new class is generated when calling new:

openapi-client/lib/OpenAPI/Client.pm

Lines 393 to 395 in a8025f9

	Returns an object of a generated class, with methods generated from the Open
	API specification located at C<$specification>. See L<JSON::Validator/schema>
	for valid versions of C<$specification>.

I don't mind a PR though, as long as it's not too complex.