Allow pre-BUILD mixins #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhthorsen
reviewed
Jun 1, 2022
| @@ -11,8 +11,6 @@ use constant DEBUG => $ENV{OPENAPI_CLIENT_DEBUG} || 0; | |||
|
|
|||
| our $VERSION = '1.03'; | |||
|
|
|||
| my $BASE = __PACKAGE__; | |||
There was a problem hiding this comment.
I can't remember why I used $BASE and not $class (or $parent). I have to look at the git log too see if I added a comment about it...
|
Can you rebase in main so we get automatic testing? |
|
Yes, will account for all the comments, thanks!
Wrt new on an object: after I did the change, I realized that new on an
object wouldn't really make sense. Should it die, or should it just crash
when it naturally would?
…On Wed, Jun 1, 2022, 04:38 Jan Henning Thorsen ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In t/client.t
<#37 (comment)>
:
> isa_ok($client, 'OpenAPI::Client');
can_ok($client, 'addPet');
+subtest 'pre-mixing roles' => sub {
Can you also update
https://github.com/jhthorsen/openapi-client/blob/main/.github/workflows/ci-ubuntu.yml#L25
to install Role::Tiny?
—
Reply to this email directly, view it on GitHub
<#37 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFURPKWQ4D5SI7M7XXE3WX3VM25IJANCNFSM5XOSGJPA>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
jhthorsen
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of what I meant for #35. Again, the issue I was having is that I
wanted to mix in a role which had defaults for attributes and other things that would
normally happen at BUILD time. Since I could only mix the behavior in after instantiation,
I had to manually pass through some of the behavior that I wanted to.
This PR simply replaces the fixed $BASE that OpenAPI::Client uses to be the parent for
generated class to instead be the dynamic one that's called.