Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build autograding process #4

Merged
merged 73 commits into from
Nov 12, 2022
Merged

Build autograding process #4

merged 73 commits into from
Nov 12, 2022

Conversation

ARaps1
Copy link
Contributor

@ARaps1 ARaps1 commented Oct 24, 2022

As a system we want to be able to auto grade a users assignments and provide the results back to the system.

Acceptance Criteria

@ARaps1
Copy link
Contributor Author

ARaps1 commented Oct 24, 2022

Clone Public Repository tests will fail as along as we don't have our backend deployed.

Copy link
Contributor

@JJamesWWang JJamesWWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you accidentally committed dist/index.js

when the action is called from other repos it looks at the dist/index.js
https://docs.github.com/en/actions/creating-actions/creating-a-javascript-action

Copy link
Contributor

@JJamesWWang JJamesWWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm inclined to ask you to find a way to make the ESLint workflow not fail - it'll be annoying if everyone else's branches break because of these changes and then it becomes hard to tell if it was their own change or these changes

Just realized a lot of the comments below don't show the ESLint error - most of them are in referral to that.

action.yml Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/util/autograder.interface.ts Outdated Show resolved Hide resolved
src/util/file-util.ts Outdated Show resolved Hide resolved
src/util/file-util.ts Show resolved Hide resolved
src/util/file-util.ts Outdated Show resolved Hide resolved
src/util/json-util.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@JJamesWWang JJamesWWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, seems we can't properly verify this until later

@ARaps1 ARaps1 merged commit d87418a into main Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants