-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build autograding process #4
Conversation
…tion into build-autograding-process
…llab/matric-github-action into build-autograding-process
…llab/matric-github-action into build-autograding-process
…llab/matric-github-action into build-autograding-process
…llab/matric-github-action into build-autograding-process
…llab/matric-github-action into build-autograding-process
Clone Public Repository tests will fail as along as we don't have our backend deployed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you accidentally committed dist/index.js
when the action is called from other repos it looks at the dist/index.js
https://docs.github.com/en/actions/creating-actions/creating-a-javascript-action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm inclined to ask you to find a way to make the ESLint workflow not fail - it'll be annoying if everyone else's branches break because of these changes and then it becomes hard to tell if it was their own change or these changes
Just realized a lot of the comments below don't show the ESLint error - most of them are in referral to that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, seems we can't properly verify this until later
As a system we want to be able to auto grade a users assignments and provide the results back to the system.
Acceptance Criteria
@actions/core
source
submission
results/results.json