Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accommodate multiple css #115

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Accommodate multiple css #115

merged 2 commits into from
Mar 9, 2023

Conversation

avahoffman
Copy link
Contributor

Purpose/implementation Section

What changes are being implemented in this Pull Request?

Attempting a solution for jhudsl/OTTR_Template#536. to accommodate:

bookdown::gitbook:
  css: [assets/style.css, assets/AnVIL_style/anvil.css]

What was your approach?

If multiple css files are provided in _output.yml, this now loops through and makes a "mega css" to proceed.

Would appreciate if others can test/gut check this!

@avahoffman avahoffman requested a review from cansavvy March 6, 2023 23:21
@cansavvy
Copy link
Contributor

cansavvy commented Mar 6, 2023

Thanks for doing this @avahoffman ! I'm gonna give this a deeper look tomorrow and get back to you.

@avahoffman
Copy link
Contributor Author

Sounds great! I am hoping to be done with messing around with our AnVIL css :)

@cansavvy
Copy link
Contributor

cansavvy commented Mar 9, 2023

Thanks for doing this @avahoffman ! I'm gonna give this a deeper look tomorrow and get back to you.

This was a lie. 🤣

@cansavvy
Copy link
Contributor

cansavvy commented Mar 9, 2023

What repositories can I test this on? Does AnVIL_Template work as a good test?

@cansavvy
Copy link
Contributor

cansavvy commented Mar 9, 2023

Also, after this does run, what can I look at in your rendered AnVIL_Template to know that the multiple css files have all been incorporated? I'm not sure what I'm looking for. @avahoffman

Copy link
Contributor

@cansavvy cansavvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I ran it locally on AnVIL_Template and I'm pretty sure it worked but was wondering what a definitive item I should look for to know that it worked?

@avahoffman
Copy link
Contributor Author

Good question haha. I tested it with toc-less.css and an 'anvil.css' both as args on _output.yml. 'anvil.css' had some css that changed the color and it appeared to work. I'll test further with a test docker image.

@avahoffman avahoffman merged commit 151e412 into main Mar 9, 2023
@avahoffman avahoffman deleted the ava/multi-css branch March 9, 2023 18:39
@cansavvy
Copy link
Contributor

cansavvy commented Mar 9, 2023

Sounds great. If that test docker image run works, then feel free to update the :main tagged docker image on jhudsl/base_ottr. Or I can also do that.

@avahoffman
Copy link
Contributor Author

@cansavvy I will take care of it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants