Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when parsing a well-known import, we also need to recursively parse its deps #222

Merged
merged 1 commit into from
Jun 12, 2019
Merged

when parsing a well-known import, we also need to recursively parse its deps #222

merged 1 commit into from
Jun 12, 2019

Conversation

jhump
Copy link
Owner

@jhump jhump commented Jun 12, 2019

Fixes #219. Alternative to #220.

@jhump jhump mentioned this pull request Jun 12, 2019
Closed
bufdev
bufdev approved these changes Jun 12, 2019
View reviewed changes
Copy link
Contributor

@bufdev bufdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me! Yep the other one was a bit copy/paste, this looks better

@jhump jhump merged commit efd29ef into master Jun 12, 2019
@jhump jhump deleted the jh/fix-issue-parsing-wk-imports branch June 12, 2019 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bufdev bufdev bufdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recursive WKT imports not properly linked
2 participants
@jhump @bufdev