Add custom boolean attribute support #503 #555
Merged
+115
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Legioth
commented
Apr 18, 2015
Legioth
commented
- Adds BooleanAttribute that writes out itself without a value
- Adds API in Element for setting boolean attributes
- Update parser to distinguish between no value and empty value
* Adds BooleanAttribute that writes out itself without a value * Adds API in Element for setting boolean attributes * Update parser to distinguish between no value and empty value
| assertFalse(div.hasAttr("false")); | ||
|
|
||
| assertEquals("<div true></div>", div.outerHtml()); | ||
| } |
There was a problem hiding this comment.
Can you assert their type here also?
|
Thanks, looks interesting. Can you check what the behavior should be for XML parsing and XML syntax output? Thinking that at least for XML syntax output, boolean attributes should actually output as empty string attributes. |
|
From what I have found, the original XHTML specification only allowed the format Latest XHTML specs also allow For attributes defined as boolean using XML Schema, the format is |
|
Carefully bumping this. |
jhy
added a commit
that referenced
this pull request
Jul 5, 2015
Add custom boolean attribute support #503
|
Thanks! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.