Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved search feature #172

Closed
lequangcuong123 opened this issue Mar 31, 2023 · 28 comments
Closed

Improved search feature #172

lequangcuong123 opened this issue Mar 31, 2023 · 28 comments

Comments

@lequangcuong123
Copy link

Hi, I have a couple of suggestions for the search function to improve the user experience. Please read carefully what I say below.

  • First suggestion: I want you to do a separate search called tag search. These tags will be fully exposed for users to choose from and of course they can select multiple tags at the same time. This is much better than having to type "category: [name or tag I need to find ] " in the search bar because it is very time consuming and the search performance is not high. In addition, users can manually add a new tag, and of course other users can also see the newly created tag and use it. The reason for this is because there are so many genres I like but there are no tags I need to search for them so I have no choice but to ask for your help.
  • Second suggestion: I would like you to add search by number of images (or filter and sort by number of images). It sounds silly but it is necessary for me in some special cases for example I need to find photos from onlyfan, pixiv premium, AI... but when I search in the usual way, most of them only find albums. less than 50 photos.
    +And lastly, here's what I'm looking forward to the most: please add search by album genre (Non-H, Image Set, Manga, Game CG,...). This feature allows searching by album type by a specific range, the convenience is not discussed anymore, making sure that the search performance will be much higher.
    Thank you for reading, hope you bring these features to the application soon. Have a good day
@jiangtian616
Copy link
Owner

jiangtian616 commented Apr 1, 2023

These tags will be fully exposed for users to choose from

I have no idea how to get these datas... If you mean it's from users can manually add a new tag, it's technically impossible because JHenTai is a totally front-end project, what you said needs a separate back-end server to store these datas which costs.

search by number of images

You means search results is filterd by multiple images in File Search? I'm sorry but it's also technically impossible too. The gallery data is stored in E-Hentai's server that not access to me, so there's no way for me to do this in case that E-Hentai provide this feature officially. By now you can search by single image instead.

search by album genre

You can choose the gallery category you want to search in search dialog i think, just tap the chips. Isn't it what you want?
image

@lequangcuong123
Copy link
Author

lequangcuong123 commented Apr 1, 2023

This is the first apology for the semantic problem, I'm not good at English, so what I say here is the result of the translation application, if you don't understand anything, please ask me so I can can be explained in more detail.

  • Regarding the "manga, artists CG..." category search problem, I admit that I missed that function, so this is my fault. As for displaying tags for ease of selection, you can create a place called "advanced search" here that will have all the tags exposed for easy searching, and Of course you can choose more tags. When there are many tags, if possible, combine it with a keyword search. If you can't, then consider the fallback of combining the tags with the existing search bar (I don't think that's a good idea).
  • Regarding the problem of searching by number of photos, it seems that you have made a mistake somewhere, what I want to find is not the album that contains the picture I need (because I'm sure you won't be able to do it). What I need is to search albums by the number of photos in an album, for example you need to find an album "X" with 25 photos, then you set the minimum limit to 25, then the app will only appear albums contain 25 photos or more than 25 photos. In addition, I want to add the ability to sort by number of photos (from low to high or vice versa) to get the best and fastest results. These two features to find and sort by number of photos are very practical, I believe you will do it. Good luck!
    Screenshot_2023-04-01-22-48-24-273_com coccoc trinhduyet
    This is an example of the tag feature that I want to talk about, you can refer to it at: https://hentaivn.run. Regarding adding tags at the request of users, if you can't do it now, please stop because this is not required for you because your ability is still limited.

@jiangtian616
Copy link
Owner

jiangtian616 commented Apr 1, 2023

then you set the minimum limit to 25, then the app will only appear albums contain 25 photos or more than 25 photos

This feature is also supported by E-Hentai search engine, you can set the page range you want in search dialog. But there exists some limits, you can check it by tapping the icon ? in dialog.

image

add the ability to sort by number of photos

Sorry but this is also technically impossible only if E-Hentai provide this feature officially. Because we search gallerys page by page, i can sort the gallerys manually in first page, but consider that you load the second page, then i need to sort all gallerys again because E-Hentai sort gallerys in upload time order rather than number of pages, this will made the gallery list totally confusing.

This is an example of the tag feature that I want to talk about, you can refer to it at: https://hentaivn.run/

I find there're not many tags in this site, but for E-Hentai, there exists 30000 more tags so far... If i made a similar feature like this, the tag list will be very long i think, which is unacceptable.
By now, when you tapping the keyword in search bar, there will be suggestions after several seconds, is this feature not enough?

@lequangcuong123
Copy link
Author

lequangcuong123 commented Apr 1, 2023

About your search feature by page number, I think that is not enough, need to be expanded to the maximum number of pages. Also I would be grateful if these albums are arranged with page numbers in a certain order and can be customized (The number of pages I am talking about is the total number of pages the album has, not the type of pages that are numbered when opening the album, they are completely different)
IMG_20230402_005345
Regarding the issue of displaying the tags above, if you have difficulty displaying about 3000 tags at once, make a pull list(there is a pull bar in the right or left corner). For convenience, the tag names will be arranged in alphabetical order. At the top there will be a small search bar just to find more accurate tags. And finally, Selected cards will be colored or ticked depending on your preference

@jiangtian616
Copy link
Owner

jiangtian616 commented Apr 2, 2023

need to be expanded to the maximum number of pages.

You mean the maximum(2000) is not enough? Sorry this limit is from E-Hentai's official search eagine, i can't do anything with that... And a gallery can't have more than 2000 images.

The number of pages I am talking about is the total number of pages the album has, not the type of pages that are numbered when opening the album, they are completely different

I can't understand well... number of page i mean is what you circled in your uploaded picture(the number of images in a gallery). If this is what you means, the reason for why sort by this can't be done is explained before.

if you have difficulty displaying about 3000 tags at once, make a pull list

The main problem is that i have no idea where to get these tag datas...

@lequangcuong123
Copy link
Author

lequangcuong123 commented Apr 2, 2023

maybe 2 out of 3 of my ideas don't work right now, so can you teach yourself how to create a pull list from sources on the internet or the webs? Maybe if you need it I can do something (I'm not sure what I need to do)

@lequangcuong123
Copy link
Author

or maybe... if E-Hentai is restricted you can try other sites you can see ( Maybe I'm a little crazy)

@jiangtian616
Copy link
Owner

create a pull list from sources on the internet or the webs?

Before i make a tag pull list, i need to get the tag datas. But E-Hentai's tag datas is private so i can't get that...

if E-Hentai is restricted you can try other sites you can see

The problem is: E-Hentai's tag has a certain format, other sites' tags are ineffective in E-Hentai's search.

@lequangcuong123
Copy link
Author

lequangcuong123 commented Apr 2, 2023

This is really complicated. If you can't get the tag data, then I would suggest you create a place in the search bar that contains the tags. When you click on it, the search bar at the top will switch to the corresponding form. Let me give you an example: I wanted to find albums tagged "darkskin", so I clicked on the tag named darkskin in your tab box (This tag here is briefly written as darkskin), After you click on that tag, above the search line will appear the search term "category:"darkskin"". The big problem here is how to include all the current tags in your application and and have them convert to the corresponding form. Although this will be more manual because it has to list the cards, overall it seems better. I think this will be lighter than before

@lequangcuong123
Copy link
Author

lequangcuong123 commented Apr 2, 2023

about incompatibility with other sites, perhaps you need to make a separate slot just to accommodate that web. This of course takes more time because it has to learn from the beginning. But all in all, it enriches your app. You can choose to agree to do this or refuse, This is just a personal opinion

@jiangtian616
Copy link
Owner

For users from other country, when you input keyword in search bar, there will be suggestions below, isn't it enough? The form is like what you said.
image

make a separate slot just to accommodate that web

This is also technically impossible because i have no idea about the cast between other sites and E-Hentai, the tag system are totally different.

@lequangcuong123
Copy link
Author

lequangcuong123 commented Apr 2, 2023

The problem is that I don't know how many tags are there and How to enter the correct tag name. In some cases I like to read new genres so I need to know exactly which tags I don't know so I can find out which albums are related to that tag.

@jiangtian616
Copy link
Owner

jiangtian616 commented Apr 2, 2023

In some cases I like to read new genres

I think this is impossible for E-Hentai now unless E-Hentai provide their tag datas. If a feature is not supported by E-Hentai officially, i can't do it probably too.

@lequangcuong123
Copy link
Author

lequangcuong123 commented Apr 2, 2023 via email

@jiangtian616
Copy link
Owner

This is not a conclusion.. This is a fact.. Technical fact.

@lequangcuong123
Copy link
Author

You can try creating an interface like the one below, remembering that everything in the arrow bar is from your app, not from E-hentai. That means you can use it EVEN WITHOUT NETWORK. You will edit that feature via an update (if you don't have them saved in the cloud). Below are pictures showing my ideas, they are numbered 1-5
Không Có Tiêu Đề7_20230402165658
Không Có Tiêu Đề7_20230402165802
Không Có Tiêu Đề7_20230402163906
Không Có Tiêu Đề7_20230402164512
Không Có Tiêu Đề7_20230402164830

@jiangtian616
Copy link
Owner

jiangtian616 commented Apr 2, 2023

The UI interface is not the key point... As your picture shows, where can i get the tag datas like Dark Skin, NTR and so on, include 30000 more tags from E-Hentai? This is the only problem.

  • E-Hentai doesn't provide their data officially.
  • Other sites' data is unsuitable because the same tag may be different in different site, i don't know the transform rules.

@lequangcuong123
Copy link
Author

This data may have to go through a manual process, collecting the cards available on E-hentai and then putting it into the application. And like I said, they are not taken or linked from E hentai but simply a "shortcut" for typing so you can program yourself without depending on E hentai

@jiangtian616
Copy link
Owner

jiangtian616 commented Apr 2, 2023

collecting the cards available on E-hentai

Are you serious? Collecting 1,000,000 more gallerys’ data in E-Hentai? This is unrealistic, and work like this is not what a application programmer should do, this should be done by data analyst, like EhTagTranslation. For my part, i will only do this work unless others provide all the tag datas.

they are not taken or linked from E hentai but simply a "shortcut" for typing so you can program yourself without depending on E hentai

This is unreasonale in my opinion, we are using E-Hentai's search engine, we must obay its search rule, means we must depend on E-Hentai. E-Hentai's tag format for search is complicated, the official format is {namespace}:{keyword}, besides, there're many operators listed in https://ehwiki.org/wiki/Gallery_Searching. Provide unformatted tag list is unreasonale and i dislike this, this is confusing.

@lequangcuong123
Copy link
Author

lequangcuong123 commented Apr 2, 2023

I apologize for my bad wording. This is what I try my best to convey to you. If there's anything you don't know, please ask me. Remember that the first two parts are from your app only, not from E-Hentai. Therefore, synchronization of these tags (including editing and updating) is not synchronized directly over the internet, but through updating your app versions - it will probably be different if you have cloud storage)
Không Có Tiêu Đề9_20230402215912

@jiangtian616
Copy link
Owner

jiangtian616 commented Apr 2, 2023

I apologize for my bad wording. This is what I try my best to convey to you. If there's anything you don't know, please ask me. Remember that the first two parts are from your app only, not from E-Hentai. Therefore, synchronization of these tags (including editing and updating) is not synchronized directly over the internet, but through updating your app versions - it will probably be different if you have cloud storage)

I think i understand what you want and you misunderstand the key point in my reply before all the way. The main problem is i have no way to get tag like netorare you mentioned or how to convert them to formatted tags. If a tag is not in format, the search is meaningless and i refuse to develop this feature. This is what i want to tell you in all my replys before.

eg. The convert process is unpredictable

For netorare, the official tag in E-Hentai include female: netorare, male: netorare and group: netorare. The single netorare is meaningless.
For timestop, the official tag in E-Hentai include temp: timestop only. The single timestop is meaningless.

@lequangcuong123
Copy link
Author

so why when i search the keyword "netorare" on the search bar it shows albums containing the tag netorare. I understand a tag will have many branches attached, but perhaps developing those branches will not be a priority right now

@jiangtian616
Copy link
Owner

jiangtian616 commented Apr 3, 2023

so why when i search the keyword "netorare" on the search bar it shows albums containing the tag netorare

This feature is provided by E-Hentai officially, although they don't provide tag datas, they support searching related tags, so i can do it in JHenTai too.
image

but perhaps developing those branches will not be a priority right now

I repeat what i said before: If a tag is not in format, the search is meaningless and i refuse to develop this feature. This is not a priority, this is necessary .

@lequangcuong123
Copy link
Author

If so, then develop at the level of finding relevant tags and rely on the diagrams and ideas that I talk about. Because, direct input is often time consuming and tags are not saved for easy searching (I'm not talking about the search history feature, but just in case you are new and the search history is empty)

@jiangtian616
Copy link
Owner

jiangtian616 commented Apr 3, 2023

finding relevant tags

I don't understand well: If you think input is time consuming and input nothing, how can i figure out which tags are relavent.

@lequangcuong123
Copy link
Author

lequangcuong123 commented Apr 3, 2023

Click on the cells that already contain the available tags, then it will type for you in the search bar. Also, if you think that choosing the right tags in E-Hentai is too difficult because you have to distinguish if this is the name of the artist or group or male or something, I think it's best to leave it as it is (netorare is left as is). netorare) and no more accompanying words. As such it will search for results related to the word netorare. This method does not seem to be very accurate, but it has helped a lot. Hope you understand it

@jiangtian616
Copy link
Owner

jiangtian616 commented Apr 3, 2023

I understand what you want from the beginning, and you don't understand my reply all the way. This is the last time i explain, i'm tired to repeat it because i have told you the same thing more than 10 times in this issue.

  • I have no way to get tag like netorare you mentioned.
  • There is no way to convert tag format like netorare -> female: netorare.
  • If a tag is not in format {namespace}:{keyoword}, the search is meaningless and i refuse to develop this feature, no matter whether it's accurate.

@lequangcuong123
Copy link
Author

lequangcuong123 commented Apr 3, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants