Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest release on pypi is 1.3.5, of which setup.py declares version 1.3.4 #107

Closed
tshirtman opened this issue Nov 30, 2020 · 28 comments
Closed

Comments

@tshirtman
Copy link

This is broken in pip>=20.3.

Considering the ageing release, it seems like it would make a new release a good idea :).

@ethanjosephscott
Copy link

I haven't tested it out however in the setup.py file lists under "version" '1.3.4' when it should be '1.3.5'. in master this field looks like this 'version=pypyodbc.version'. With the repository founder seemingly awol are we capable of doing a release?

@braian87b
Copy link
Collaborator

braian87b commented Dec 10, 2020

Hi !

#79 (comment)
#89
#88 (comment)
#82

@ethanjosephscott
Copy link

ethanjosephscott commented Dec 10, 2020

Hey @braian87b If you would give me the necessary access, I would take the time and effort to get this straightened out. I have found the author's personal social media page. So I will be reaching out to him to hopefully gain access to the pypi repository.

@braian87b
Copy link
Collaborator

braian87b commented Dec 10, 2020

@ethanjosephscott We should get in touch with @jiangwen365 since I just checked and currently I do not have permissions on the repo to add new collaborators.

@ethanjosephscott
Copy link

ethanjosephscott commented Dec 10, 2020

@braian87b Okay i just sent him an email on a different but actively maintained project of his, because we would need a Chinese national to signup for said social media website. I have added my email address to my profile if you would wish for me to share his contact details. I would like to retain some privacy and respect to the developer.

@rolweber
Copy link

Two months since the last comment - I suppose no response from the project creator.
If there's serious interest in getting a new release out, it may be necessary to fork this repo.

I could write up the steps for you, @braian87b. Should take an hour or less, depending on how good you are with writing. Afterwards, you'd be the administrator of the forked repo and could grant people access.

But after a fork and new release, the lengthy process to get access to the abandoned PyPI project is waiting for any volunteers.

@braian87b
Copy link
Collaborator

@rolweber Hey, Let me know what should I do.

@rolweber
Copy link

  1. Create a new organization "pypyodbc" on GitHub.
  2. Prepare the current repo for the fork. Put in links to the new repo, although that doesn't exist yet. This is important to establish authenticity of the new repo.
    • Add a section to the top of README.md, explaining that development moves to the new repo. Where it currently says "This is the GitHub homepage of pypyodbc".
      Phrase the explanation in a way that will also work when it appears in the new repo :-)
    • Create an issue template that says "Development has moved. Please open new issues at newrepo/issues".
    • Create a PR template that says "Development has moved. Please open PRs for newrepo instead."
    • Once you're satisified with the README and templates, create a tag "move-to-pypyodbc-org" or similar, to mark the point of departure.
  3. Create a copy of this repo in the new org, with the name chosen above. There are different ways to copy the repo. Either way, the issues and pending PRs will remain here. The Wiki needs to be copied separately.
    • Use the GitHub importer in the new org to import this repo.
    • Alternatively, fork this repo into the new org. Then contact GitHub support to detach the fork from its upstream. Otherwise, PRs in the fork would be opened against upstream by default, which is terribly annoying.
    • Alternatively, clone this repo to your workstation. Create a new, empty repo in the new org. Really empty, not even a read me. In the clone on your workstation, configure the new repo as an upstream. Push your clone to the new repo.
  4. Clean up the new repo:
    • Go to Settings and enable Issues. (Depending on how you created the copy, this might already be enabled.)
    • Edit README.md, explaining that this is the new home of pypyodbc. Provide a back link to the former repo.
    • Remove the issue template and PR template.
  5. Optionally, can be done later: Copy the wiki from this repo to the new one.
  6. If possible, make @jiangwen365 an editor of the new org or repo. They probably don't care, but it's a matter of courtesy and recognition. I'm not sure though if you can grant someone access without them accepting it.

I hope I didn't miss anything of importance :-)

braian87b added a commit that referenced this issue Mar 4, 2021
@braian87b
Copy link
Collaborator

Alright, 🚀

It's live here: https://github.com/pypyodbc/pypyodbc

  • I skipped the tag "move-to-pypyodbc-org" part (was it necessary?)
  • I used the GitHub importer
  • Issues seems to be already enabled
  • Didn't copied the wiki, can you please try to do that step?
  • I invited @jiangwen365 but the invite is pending to be accepted

@braian87b
Copy link
Collaborator

@rolweber let me know further steps, will be attentive.

@rolweber
Copy link

rolweber commented Mar 4, 2021

If nothing gets merged in the old repo anymore, creating a tag is not required. The idea was that anyone who cares can easily find out at which point the fork took place.

@rolweber
Copy link

rolweber commented Mar 4, 2021

You can remove the stale branches from the new repo :-)

Actually, I could do that as well :-) Thanks for the invitation.

@rolweber
Copy link

rolweber commented Mar 4, 2021

I tagged the last common commit in the new repo:
https://github.com/pypyodbc/pypyodbc/releases/tag/point-of-departure

@rolweber
Copy link

rolweber commented Mar 4, 2021

Don't know yet when I will find time to look into the Wiki migration. But I guess there's no hurry.

@rolweber
Copy link

rolweber commented Mar 8, 2021

I copied the wiki. And I figured out which commit was last released to PyPI. That is now tagged as a version:
https://github.com/pypyodbc/pypyodbc/releases/tag/v1.3.5

How do you feel about renaming the master branch to main? Some people are offended by the term.

@braian87b
Copy link
Collaborator

done.

@sodul
Copy link

sodul commented Apr 28, 2021

@rolweber @braian87b are you in the process of claiming ownership of pypyodbc on PyPI? We have pinned our own requirements.txt to pypyodbc==1.3.2 to avoid pip complaints, so there is no rush to get the ball moving.

@rolweber
Copy link

I'm not. Neither am I planning to.

Maybe some volunteer steps up to handle the administrative stuff? Search for historical records about failed attempts to reach @jiangwen365, make some new attempts, tell the PyPI admins about it, try again after some weeks,...

I have neither the patience nor the motivation required for that.

@rolweber
Copy link

@braian87b Do you have an account on PyPI? Assuming that a volunteer steps up, it would make sense to transfer ownership of the PyPI project to you. You're the only person around who has write access to the original repo. I think that will go a long way to convince the PyPI admins that the project would be safe with you.

@nickolay
Copy link

nickolay commented Jun 1, 2021

@braian87b Do you have an account on PyPI? Assuming that a volunteer steps up, it would make sense to transfer ownership of the PyPI project to you. You're the only person around who has write access to the original repo. I think that will go a long way to convince the PyPI admins that the project would be safe with you.

I fired an email to @jiangwen365 (the only e-mail I found was the one listed on the pypi page) asking them to look into this, though previous attempts apparently didn't have any result.

The PEP-541 process requires filling in a form with the PyPI username of the new maintainer, so unless @braian87b or someone else steps up and shares their pypi username, no volunteer can help with the name transfer..

@braian87b
Copy link
Collaborator

Let me take a look, right now.

@braian87b
Copy link
Collaborator

Alright, I just set up the request here: pypi/support#1133

@sodul
Copy link

sodul commented Sep 27, 2021

The transfer completed!

@sodul
Copy link

sodul commented Oct 27, 2021

@braian87b you are the owner now, will you release 1.3.6 to fix the versioning issue?

@nickolay
Copy link

nickolay commented Nov 2, 2021

I tried looking into what needs to happen for a 1.3.6 release.

First during my attempt to locate sources for the latest (2017-01-30) release on PyPI, I noticed that https://github.com/pypyodbc/pypyodbc/releases/tag/v1.3.5 points to a wrong commit. The correct one is 044227a, but it doesn't exactly match what's on PyPI either (in its setup.py / PKG-INFO metadata)

I tried bringing setup.py closer to what's on currently on PyPI in nickolay/pypyodbc@5680714#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7

I believe the least invasive way to release 1.3.6 (with only a fix to the versioning problem, and without any other breaking changes such as pypyodbc/pypyodbc#5) is to build the source distribution (python setup.py sdist) from https://github.com/nickolay/pypyodbc/tree/568071444cf0dc442801749797faec2da7815952 and then follow the instructions at https://packaging.python.org/tutorials/packaging-projects/#uploading-the-distribution-archives to publish to (Test)PyPI. Can anyone double-check?

@braian87b can you make a test pypi release, please?

@rolweber
Copy link

rolweber commented Dec 3, 2021

Thanks for spotting the problems with the commit I tagged as suspect for 1.3.5.2. I've linked your comment in the release description now. I'll try to free up a few hours later this month for working towards a re-release. The project isn't on test.pypi yet, so that's something I might be able to do.

@rolweber
Copy link

Release 1.3.6 from pypyodbc/pypyodbc is published on PyPI now: https://pypi.org/project/pypyodbc/1.3.6/

@tshirtman or @braian87b, could you please close this issue? I don't have the permission to do that.

@tshirtman
Copy link
Author

tshirtman commented Dec 23, 2021

Done! Thanks for the work to take over and fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants