Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-release 1.3.5.2 as 1.3.6 #9

Closed
13 tasks done
rolweber opened this issue Dec 21, 2021 · 16 comments
Closed
13 tasks done

Re-release 1.3.5.2 as 1.3.6 #9

rolweber opened this issue Dec 21, 2021 · 16 comments
Assignees

Comments

@rolweber
Copy link
Collaborator

rolweber commented Dec 21, 2021

Let's see what needs to be done to finally get rid of the pip errors.
Thanks @nickolay for your work in this comment.

If the artifact(s) on test PyPI are OK...

@rolweber
Copy link
Collaborator Author

As @nickolay figured out and recorded in commit nickolay@fc2c9a4, the PKG-INFO file of the archive published on PyPI was not generated from the setup.py file we have in the git history. I'm not going to try and re-create the package description.

rolweber added a commit that referenced this issue Dec 21, 2021
rolweber added a commit that referenced this issue Dec 21, 2021
@braian87b
Copy link
Contributor

Hey, I have permissions on the repo, let me know if anyone need me to do something.

@rolweber
Copy link
Collaborator Author

@braian87b Thanks! My username on PyPI is rolweber. Could you give me access to the pypyodbc project there?

@braian87b
Copy link
Contributor

@rolweber done

@braian87b
Copy link
Contributor

@rolweber I have plans to do a massive rewrite of the library starting on march to easily improve the tests, latest python3 and sqlalchemy full compatibilty, but first will be handy to browse all the forks and see if there is some interesting fixes and improvements to be merged here, that will be a lot of work but maybe someone can here can give a hand on that.

@rolweber
Copy link
Collaborator Author

Do you mind that I want to re-publish the old release with an empty list of maintainers? The project has been effectively dormant for five years now, afaict.

@rolweber
Copy link
Collaborator Author

Status update: I've got the release tagged, and a manually built artifact attached.
https://github.com/pypyodbc/pypyodbc/releases/tag/v1.3.6rc1

Will try the upload to test PyPI tomorrow.

@braian87b If you have an account on https://test.pypi.org/, I can give you access to the project there once it exists :-) Unless someone beats me to it.

@braian87b
Copy link
Contributor

Do you mind that I want to re-publish the old release with an empty list of maintainers? The project has been effectively dormant for five years now, afaict.

No problem for me.

@braian87b
Copy link
Contributor

Status update: I've got the release tagged, and a manually built artifact attached. https://github.com/pypyodbc/pypyodbc/releases/tag/v1.3.6rc1

Will try the upload to test PyPI tomorrow.

@braian87b If you have an account on https://test.pypi.org/, I can give you access to the project there once it exists :-) Unless someone beats me to it.

nice, it's braian87b

@rolweber
Copy link
Collaborator Author

The package is on test.pypi now: https://test.pypi.org/project/pypyodbc/1.3.6rc1/

I could successfully install it with pip 21.2.4.

@rolweber
Copy link
Collaborator Author

@braian87b You're invited to the project on test.pypi.

browse all the forks and see if there is some interesting fixes and improvements to be merged here

I'd be careful with that. Just because somebody forked the project and uploaded changes to their fork doesn't mean they're OK with those changes floating upstream. The MIT license does not require changes to be licensed under MIT as well. You'll be safer if you just stick to scanning the PRs that were submitted against the original project. If somebody pointed to their fork in an issue comment, like nickolay did, that is also an invitation to pick up their changes.

rolweber added a commit that referenced this issue Dec 22, 2021
@rolweber
Copy link
Collaborator Author

I'll wait until tomorrow for feedback on the test pypi release. If no issues are raised, I'm planning to build and publish the 1.3.6 release tomorrow.

@nickolay
Copy link

The package is on test.pypi now: https://test.pypi.org/project/pypyodbc/1.3.6rc1/

Works for me. Thanks for pushing this through!

@braian87b
Copy link
Contributor

I'd be careful with that.

Yes, but actually saw interesting fixes for some bugs that will be handy to be picked up, obviously we can prior send a message the the fork authors and/or check license changes. I don't remember now but I saw at least two or three things that may worth to take a look into it.

@rolweber
Copy link
Collaborator Author

Done.

@rolweber
Copy link
Collaborator Author

I have plans to do a massive rewrite of the library starting on march

@braian87b I guess those plans got delayed a bit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants