RT #119949: Correctly concat prefix on directories #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an incorrectly handled tarball to the roundtrip tests.
When concatenating the prefix & name fields of a tar header, any trailing slashes in the name would be stripped off. Re-add the trailing slash for consistency with other directories in the tarball.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When concatenating the prefix & name fields of a tar header, any trailing slashes in the name would be stripped off when the full_path is reported. Re-add the trailing slash for consistency with other directories in the tarball.
Additionally, add a test to show the issue in action.