Don't regenerate the required options every time in _add_module_object()

jib · Apr 22, 2012 · 26bd52c · 26bd52c
1 parent b935c23
commit 26bd52c
Showing 1 changed file with 23 additions and 18 deletions.
diff --git a/lib/CPANPLUS/Internals/Source/Memory.pm b/lib/CPANPLUS/Internals/Source/Memory.pm
@@ -122,29 +122,34 @@ sub _add_author_object {
     return $obj;
 }
 
-sub _add_module_object {
-    my $self = shift;
-    my %hash = @_;
+{
+    my @required_opts = map { $_ => { required => 1 } } qw[
+        module version path comment author package description dslip mtime
+    ];
 
-    my $class;
-    my $tmpl = {
-        class   => { default => 'CPANPLUS::Module', store => \$class },
-        map { $_ => { required => 1 } }
-            qw[ module version path comment author package description dslip mtime ]
-    };
+    sub _add_module_object {
+        my $self = shift;
+        my %hash = @_;
 
-    my $href = do {
-        local $Params::Check::NO_DUPLICATES = 1;
-        local $Params::Check::SANITY_CHECK_TEMPLATE = 0;
-        check( $tmpl, \%hash ) or return;
-    };
+        my $class;
+        my $tmpl = {
+            class   => { default => 'CPANPLUS::Module', store => \$class },
+            @required_opts,
+        };
 
-    my $obj = $class->new( %$href, _id => $self->_id );
+        my $href = do {
+            local $Params::Check::NO_DUPLICATES = 1;
+            local $Params::Check::SANITY_CHECK_TEMPLATE = 0;
+            check( $tmpl, \%hash ) or return;
+        };
 
-    ### Every module get's stored as a module object ###
-    $self->module_tree->{ $href->{module} } = $obj or return;
+        my $obj = $class->new( %$href, _id => $self->_id );
 
-    return $obj;
+        ### Every module get's stored as a module object ###
+        $self->module_tree->{ $href->{module} } = $obj or return;
+
+        return $obj;
+    }
 }
 
 {   my %map = (