Fix Userlists: Don't overwrite page parameter #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
line 20 specifically excludes "page" among other keys
Merge pull request jikan-me#450 from Vernoxvernax/master
pushrbx
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request depends on #452.
The array from line
20specifically excludespageamong other keys.Additionally, the constructor of both
UserAnimeListRequestandUserMangaListRequestalready specify optional values forpage.In the return line, the correct page key has previously been overwritten using the values from the
valuesarray, or at least that's what I think.It works for me, but please test before merging.