Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced Pongo instances with MongoClient. #27

Merged
merged 13 commits into from Sep 25, 2014
Merged

Replaced Pongo instances with MongoClient. #27

merged 13 commits into from Sep 25, 2014

Conversation

IonicaBizau
Copy link
Collaborator

  • implemented callback buffering
  • first step to remove Pongo as dependency
  • other improvements in storing options

Fixes #6

  • Replace Pongo completely
  • Use MongoClient connections
  • Callback buffering
  • Remove Pongo as dependency
  • Server object cache (wontfix)
  • Client object cache

@IonicaBizau
Replaced Pongo instances with MongoClient.
7b8c601 
 - implemented callback buffering
 - first step to remove Pongo as dependency
 - other improvements in storing options
@IonicaBizau IonicaBizau self-assigned this Sep 24, 2014
@IonicaBizau
Copy link
Collaborator Author

/cc @adioo

@IonicaBizau
Added missing semicolons. Updated syntax
c46c94c
@IonicaBizau
Lot of syntax fixes
8da040b 
 - beautified js files
 - added missing semicolons
 - deleted unnecesary semicolons
 - double quotes
 - renamed some variables
@IonicaBizau
Regenerated package.json. Added test command and other fields
12392f3
@IonicaBizau
Copy link
Collaborator Author

It seems we cannot cache server objects because of the following error:

A Server or ReplSet instance cannot be shared across multiple Db instances

@IonicaBizau
Cache server objects
96f46fa 
Also added the tests for server object caching. However, they fail because of an error thrown from Mongo driver.
@IonicaBizau
Client object cache
3d36252
@IonicaBizau
args instead of arguments
07e59b7
@IonicaBizau
Removed debugger lines
33cfcc7
@IonicaBizau
Copy link
Collaborator Author

I introduced client object caching here: 3d36252, so we won't open new connections if we already have the client (cached one).

IonicaBizau added a commit that referenced this pull request Sep 25, 2014
@IonicaBizau
Merge pull request #27 from adioo/mongoclient
269a85b 
Replaced Pongo instances with MongoClient.
@IonicaBizau IonicaBizau merged commit 269a85b into master Sep 25, 2014
@IonicaBizau IonicaBizau deleted the mongoclient branch September 25, 2014 14:51
@IonicaBizau IonicaBizau restored the mongoclient branch September 25, 2014 14:54
@IonicaBizau IonicaBizau deleted the mongoclient branch September 25, 2014 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@IonicaBizau IonicaBizau

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace pongo with MongoClient
1 participant
@IonicaBizau