Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from at_exit to finalizer to avoid squashing test exit code. #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nmeans
Copy link

@nmeans nmeans commented May 1, 2013

Using at_exit can unintentionally squash the exit status of the including application's test suite, causing the suite to always return an exit status of 0 even when tests are failing. This causes CI platforms like Travis that rely on test exit status for determining the status of a given build. This commit uses a finalizer to trigger the same buffer flush without interfering with test suite exit status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant