Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have Default Action be Single Upload of the Current Directory #2

Closed
jimjkelly opened this issue Apr 18, 2016 · 3 comments
Closed

Have Default Action be Single Upload of the Current Directory #2

jimjkelly opened this issue Apr 18, 2016 · 3 comments

Comments

@jimjkelly
Copy link
Owner

As requested in issue #1, it might make more sense that the default deploy action is to deploy the current directory as a single Lambda, and only search for multiple Lambdas if the -d option is given. Some things to consider:

  • We'll want to filter out .env files then, since we don't want to by default upload their credentials
  • Is there any value in confirming that the entry point as specified exists? Probably. That could be good in either case.
@m0ngr31
Copy link

m0ngr31 commented Apr 18, 2016

I made a PR, for the most basic of handling this. I'll need to dig in a bit more and see about the other stuff.

jimjkelly added a commit that referenced this issue Apr 28, 2016
@jimjkelly
Upload Single Lambda Dir
1eb1a66 
This changes how we do things, pursuant to #2, to only upload
a single Lambda dir at a time, either the CWD or whatever
is specified by `-d`.

We try to take care to be careful not to upload .env files.

I've added an example for how to upload multiple Lambdas in a
CI environment.
@jimjkelly jimjkelly mentioned this issue Apr 28, 2016
Merged
@jimjkelly
Copy link
Owner Author

I created PR #4 to address some of the issues that we discussed - I'm going to play with it a bit over the next day or two but it seems to work correctly. Feel free to give it a gander and test it out and if you have any issues/ideas feel free to let me know. I'l merge it in a couple days if I don't find anything.

jimjkelly added a commit that referenced this issue Apr 29, 2016
@jimjkelly
Upload Single Lambda Dir (#4)
70c1290 
This changes how we do things, pursuant to #2, to only upload
a single Lambda dir at a time, either the CWD or whatever
is specified by `-d`.

We try to take care to be careful not to upload .env files.

I've added an example for how to upload multiple Lambdas in a
CI environment.
@jimjkelly
Copy link
Owner Author

Resolved by #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jimjkelly @m0ngr31