Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let users set any SSL options they want #30

Closed
wants to merge 1 commit into from
Closed

Let users set any SSL options they want #30

wants to merge 1 commit into from

Conversation

jpnurmi
Copy link
Contributor

@jpnurmi jpnurmi commented Oct 27, 2014

No description provided.

@jpnurmi
Copy link
Contributor Author

jpnurmi commented Oct 27, 2014

I got this idea that since Csocket.h does not attempt to hide OpenSSL but includes <openssl/ssl.h>, how about allowing users to use SSL_OP_XXX (eg. SSL_OP_NO_COMPRESSION) directly for maximum flexibility?

@jimloco
Copy link
Owner

jimloco commented Oct 27, 2014

You are correct that Csocket has only done a moderately sufficient job at obscuring openssl, ie SSL, SSL_CTX, X509 as they are obviously more than trivial structures that are hard to work without making abstracted based classes and so forth. However, simple types I don't really mind wrapping and I actually like grouping some of these types into logical buckets as enums. Additionally, the cases in which users actually have to interact with openssl directly is actually limited and I only have a few spots that are like that for edge cases and I would prefer to keep it that way.

@jpnurmi
Copy link
Contributor Author

jpnurmi commented Oct 27, 2014

Ok. Could you either add an option or just disable SSL compression?

@jimloco
Copy link
Owner

jimloco commented Oct 30, 2014

Added DisableSSLCompression()

@jpnurmi jpnurmi deleted the ssl-opts branch October 30, 2014 08:27
@jpnurmi
Copy link
Contributor Author

jpnurmi commented Oct 30, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants