Jimp stucking at a corrupted GIF file

[nodegin]

I found this GIF file will cause Jimp stuck forever (right click to save):

Code snippet for reproducing this issue:

const Jimp = require('jimp')

Jimp.read(`1.gif`, (err, image) => {
  console.log(image, err)
})

[jtlapp]

Thanks for this. I'm writing a package that adds GIF support to Jimp by wrapping it, will see if I can fix it in my wrapping module.

[jtlapp]

omggif.js is hanging. The GIF appears to be ill-formed, but the decoder shouldn't be hanging. I think it's fair to simply reject the image. I'll look into it.

No one is maintaining Jimp any more, but I'll be able to fix it from my GIF wrapper. You don't want to be using Jimp directly for GIFs anyway.

[nodegin]

@jtlapp Nice work for finding out what the problem is.

[jtlapp]

I've provided GIF support and a working decoder in gifwrap. Thanks for finding the bug and providing a test case.

[hipstersmoothie]

@jtlapp any reason why you didn't try to add GIF support directly to jimp?

[jtlapp]

Oh sorry, somehow I missed the question. There are two issues related to GIF support. One is getting single frame GIFs to load at all. The problem was in omggif. I submitted the problem to omggif along with a solution, although the author opted for a different solution. Use the existing omggif repo, instead of a local copy. and this problem will go away.

The second issue with GIFs is supporting animations. Jimp is architected to operate on exactly one image at a time. All the stuff that's needed to support GIF animations is outside the purview of Jimp. It's stuff that would wrap Jimp. I attempted to wrap Jimp but found the Jimp constructors so non-standard that it wasn't possible without great headache. Instead, I made a Jimp-compatible solution that allows you to copy the bitmap back and forth between Jimp and gifwrap.

I guess the final reason is that Jimp is written inefficiently and applies a mistaken understanding of async callbacks. I didn't want to build anything on it.