Is an 'auto-crop' feature scheduled?

[marcolino]

Is an auto-crop feature scheduled any point in time?

I mean: some images have one-color borders, which can be sometimes annoying, something that distracts from the real image contents...

I suppose it should not be so difficult, to implement (knowing the inners of jimp... :-): you should check the colors of the most external pixel for each one of the four borders: if they are all the same, you should crop that side by one pixel, and continue with the next pixel...

As an edge case, you could finish with an empty image (if the source image was just one color)... That should be fine, of course (auto-cropping one-color image is a quite silly operation in itself... :-).

For example, from:

to:

[gcq]

jimp is so lowe level and so straightforward to use that a feature like that, so specific, would not add much value and instead add complexity.

You layed out the algorithm, now it's a matter of implementing it 😄

[marcolino]

Yup! I did never read throughtfully jimp docs, now I see there is a getPixelColor(x, y) method... So yes, I'll try to implement an autocrop() method myself... Or should I directly use bitmap data, to improve performance?

[oliver-moran]

@marcolino, I'm happy to include in an auto-crop method. If you implement it and make a pull request, I'll happily pull it in. Alternatively, if you can write a simple method using the API and post it here, I'll add it to the code base.

[marcolino]

Hi!
I'm trying to git push origin autocrop-branch, to easily create a PR, but am I supposed to know repository authentication, to push a branch?

[oliver-moran]

1. Create a fork by clicking the link in the top right here: https://github.com/oliver-moran/jimp
2. Check that out, make your modifications and save your changes to the fork.
3. Then go here and create a new pull request: https://github.com/oliver-moran/jimp/pulls

[marcolino]

Yes... I forgot to fork, but did clone directly from your repo... :-(
Sorry, it's a long time from my last PR... :-)
Please let me now what you think about the autocrop feature...

[oliver-moran]

Merged the pull request here: #71

Thanks!

[marcolino]

Sorry, last question: I have already some minor changes to autocrop... Should I create a new PR, or what?

[oliver-moran]

Sure thing, just create a new pull request from the fork you have.

I think you might even be able to do it in the same thread: #71