[New Feature] Autocrop #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcolino
changed the title
|
Love the user of JS labels! I've never seen them used in anger before. Very nice. Merged now. Will test and include in the next release. Thanks! |
|
:-) Thanks to you! Marco Solari On 17 November 2015 at 14:01, Oliver Moran notifications@github.com wrote:
|
iwsfg
reviewed
Nov 30, 2016
| widthOfPixelsToCrop >= 0 ? widthOfPixelsToCrop : 0; | ||
| var heightOfPixelsToCrop = h - (southPixelsToCrop + northPixelsToCrop); | ||
| heightOfPixelsToCrop >= 0 ? heightOfPixelsToCrop : 0 | ||
|
|
There was a problem hiding this comment.
"Safety checks" do not work. Should probably be
var widthOfPixelsToCrop = w - (westPixelsToCrop + eastPixelsToCrop);
var heightOfPixelsToCrop = h - (southPixelsToCrop + northPixelsToCrop);
widthOfPixelsToCrop = widthOfPixelsToCrop >= 0 ? widthOfPixelsToCrop : 0;
heightOfPixelsToCrop = heightOfPixelsToCrop >= 0 ? heightOfPixelsToCrop : 0;or more compact
var widthOfPixelsToCrop = Math.max(0, w - westPixelsToCrop - eastPixelsToCrop);
var heightOfPixelsToCrop = Math.max(0, h - southPixelsToCrop - northPixelsToCrop);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autocrop feature added.
Not particularly smart algorithm, but it looks like it does its job... :-)
I did not update the README...