Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove compiling polyfills into published code #891

Merged
merged 2 commits into from May 17, 2020
Merged

Remove compiling polyfills into published code #891

merged 2 commits into from May 17, 2020

Conversation

danez
Copy link
Contributor

@danez danez commented May 16, 2020

What's Changing and Why

After core-js has been removed jimp does not work anymore out of the box as core-js is still required in the compiled output. By removing the corejs configuration from the babel config it will not be compiled into the output anymore and start working again.

Fixes #890

Release Notes

This also drops support for node 6.14.

Tasks

  • Add tests
  • Update Documentation
  • Update jimp.d.ts
  • Add SemVer Label
📦 Published PR as canary version: 0.11.1-canary.891.908.0

✨ Test out this PR locally via:

npm install @jimp/cli@0.11.1-canary.891.908.0
npm install @jimp/core@0.11.1-canary.891.908.0
npm install @jimp/custom@0.11.1-canary.891.908.0
npm install jimp@0.11.1-canary.891.908.0
npm install @jimp/plugin-blit@0.11.1-canary.891.908.0
npm install @jimp/plugin-blur@0.11.1-canary.891.908.0
npm install @jimp/plugin-circle@0.11.1-canary.891.908.0
npm install @jimp/plugin-color@0.11.1-canary.891.908.0
npm install @jimp/plugin-contain@0.11.1-canary.891.908.0
npm install @jimp/plugin-cover@0.11.1-canary.891.908.0
npm install @jimp/plugin-crop@0.11.1-canary.891.908.0
npm install @jimp/plugin-displace@0.11.1-canary.891.908.0
npm install @jimp/plugin-dither@0.11.1-canary.891.908.0
npm install @jimp/plugin-fisheye@0.11.1-canary.891.908.0
npm install @jimp/plugin-flip@0.11.1-canary.891.908.0
npm install @jimp/plugin-gaussian@0.11.1-canary.891.908.0
npm install @jimp/plugin-invert@0.11.1-canary.891.908.0
npm install @jimp/plugin-mask@0.11.1-canary.891.908.0
npm install @jimp/plugin-normalize@0.11.1-canary.891.908.0
npm install @jimp/plugin-print@0.11.1-canary.891.908.0
npm install @jimp/plugin-resize@0.11.1-canary.891.908.0
npm install @jimp/plugin-rotate@0.11.1-canary.891.908.0
npm install @jimp/plugin-scale@0.11.1-canary.891.908.0
npm install @jimp/plugin-shadow@0.11.1-canary.891.908.0
npm install @jimp/plugin-threshold@0.11.1-canary.891.908.0
npm install @jimp/plugins@0.11.1-canary.891.908.0
npm install @jimp/test-utils@0.11.1-canary.891.908.0
npm install @jimp/bmp@0.11.1-canary.891.908.0
npm install @jimp/gif@0.11.1-canary.891.908.0
npm install @jimp/jpeg@0.11.1-canary.891.908.0
npm install @jimp/png@0.11.1-canary.891.908.0
npm install @jimp/tiff@0.11.1-canary.891.908.0
npm install @jimp/types@0.11.1-canary.891.908.0
npm install @jimp/utils@0.11.1-canary.891.908.0
# or 
yarn add @jimp/cli@0.11.1-canary.891.908.0
yarn add @jimp/core@0.11.1-canary.891.908.0
yarn add @jimp/custom@0.11.1-canary.891.908.0
yarn add jimp@0.11.1-canary.891.908.0
yarn add @jimp/plugin-blit@0.11.1-canary.891.908.0
yarn add @jimp/plugin-blur@0.11.1-canary.891.908.0
yarn add @jimp/plugin-circle@0.11.1-canary.891.908.0
yarn add @jimp/plugin-color@0.11.1-canary.891.908.0
yarn add @jimp/plugin-contain@0.11.1-canary.891.908.0
yarn add @jimp/plugin-cover@0.11.1-canary.891.908.0
yarn add @jimp/plugin-crop@0.11.1-canary.891.908.0
yarn add @jimp/plugin-displace@0.11.1-canary.891.908.0
yarn add @jimp/plugin-dither@0.11.1-canary.891.908.0
yarn add @jimp/plugin-fisheye@0.11.1-canary.891.908.0
yarn add @jimp/plugin-flip@0.11.1-canary.891.908.0
yarn add @jimp/plugin-gaussian@0.11.1-canary.891.908.0
yarn add @jimp/plugin-invert@0.11.1-canary.891.908.0
yarn add @jimp/plugin-mask@0.11.1-canary.891.908.0
yarn add @jimp/plugin-normalize@0.11.1-canary.891.908.0
yarn add @jimp/plugin-print@0.11.1-canary.891.908.0
yarn add @jimp/plugin-resize@0.11.1-canary.891.908.0
yarn add @jimp/plugin-rotate@0.11.1-canary.891.908.0
yarn add @jimp/plugin-scale@0.11.1-canary.891.908.0
yarn add @jimp/plugin-shadow@0.11.1-canary.891.908.0
yarn add @jimp/plugin-threshold@0.11.1-canary.891.908.0
yarn add @jimp/plugins@0.11.1-canary.891.908.0
yarn add @jimp/test-utils@0.11.1-canary.891.908.0
yarn add @jimp/bmp@0.11.1-canary.891.908.0
yarn add @jimp/gif@0.11.1-canary.891.908.0
yarn add @jimp/jpeg@0.11.1-canary.891.908.0
yarn add @jimp/png@0.11.1-canary.891.908.0
yarn add @jimp/tiff@0.11.1-canary.891.908.0
yarn add @jimp/types@0.11.1-canary.891.908.0
yarn add @jimp/utils@0.11.1-canary.891.908.0

@hipstersmoothie hipstersmoothie added the minor Increment the minor version when merged label May 17, 2020
@hipstersmoothie
Copy link
Collaborator

Releasing as a minor since this seems to break support for node 6. but that's super old anyway

@hipstersmoothie hipstersmoothie merged commit 697f2a6 into jimp-dev:master May 17, 2020
@hipstersmoothie
Copy link
Collaborator

🚀 PR was released in v0.12.0 🚀

@hipstersmoothie hipstersmoothie added the released This issue/pull request has been released. label May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Cannot find module 'core-js/modules/es.symbol'
2 participants