Children attach improvement #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s the known issue of non-captured detached children windows during start, especially Putty, due to refocusing tricks conflict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a long time outstanding issue, there during launch some PuTTY processes could stay detached(Float state), and nothing would connect them back in the same SP run. Chances of this increased with the number of open sessions and was almost non-existent below 10. However for ~20 sessions, yet still quite rare it could occur, requiring one SP restart at most cases.
So I ignored the issue for years.
However, recently I've upgraded my VM Windows 10 from 1809 to new 21H2, and now the issue became interminent(9/10 runs SP loads with this issue). I've tested by reverting the VM snapshot to old Win10, there SP worked well again.
So i started to research into this and it was long process. Today I found that some extra delay between Start and WaitForInputHandle calls, had a positive effect on this and continued to investigate. I've updated the children start code to load it maximized initially(As AttachToWindow always maximizes it later), and SP now always starts properly(Without extra delay).
So it seems like timing issue of waiting for input and Putty window possibly starting minimized sometimes, or something like that.