Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DST fixes #175

Merged
merged 4 commits into from
Jun 28, 2018
Merged

DST fixes #175

merged 4 commits into from
Jun 28, 2018

Conversation

phreaker0
Copy link
Collaborator

sanoid uses the local time for snapshot names and planning, this patch adds correct DST handling to avoid current problems with multiple daily snapshots in the same day and a missing hourly snapshot when DST ends.
I also added a test to verify the correct behaviour of the patch.

The one thing we have to decide is how to name the duplicate hourly timestamp which is occurring when DST ends and the hour is turned back by one. The patch currently uses "_y" before the hourly snapshot type, it doesn't have a special reason.

Fixes #155

@phreaker0
Copy link
Collaborator Author

The resulting snapshot list currently looks like this:

sanoid-test-2@autosnap_2017-10-28_00:00:00_daily
sanoid-test-2@autosnap_2017-10-28_00:00:00_hourly
sanoid-test-2@autosnap_2017-10-28_00:00:00_monthly
sanoid-test-2@autosnap_2017-10-28_01:00:00_hourly
sanoid-test-2@autosnap_2017-10-28_02:00:00_hourly
sanoid-test-2@autosnap_2017-10-28_03:00:00_hourly
sanoid-test-2@autosnap_2017-10-28_04:00:00_hourly
sanoid-test-2@autosnap_2017-10-28_05:00:00_hourly
sanoid-test-2@autosnap_2017-10-28_06:00:00_hourly
sanoid-test-2@autosnap_2017-10-28_07:00:00_hourly
sanoid-test-2@autosnap_2017-10-28_08:00:00_hourly
sanoid-test-2@autosnap_2017-10-28_09:00:00_hourly
sanoid-test-2@autosnap_2017-10-28_10:00:00_hourly
sanoid-test-2@autosnap_2017-10-28_11:00:00_hourly
sanoid-test-2@autosnap_2017-10-28_12:00:00_hourly
sanoid-test-2@autosnap_2017-10-28_13:00:00_hourly
sanoid-test-2@autosnap_2017-10-28_14:00:00_hourly
sanoid-test-2@autosnap_2017-10-28_15:00:00_hourly
sanoid-test-2@autosnap_2017-10-28_16:00:00_hourly
sanoid-test-2@autosnap_2017-10-28_17:00:00_hourly
sanoid-test-2@autosnap_2017-10-28_18:00:00_hourly
sanoid-test-2@autosnap_2017-10-28_19:00:00_hourly
sanoid-test-2@autosnap_2017-10-28_20:00:00_hourly
sanoid-test-2@autosnap_2017-10-28_21:00:00_hourly
sanoid-test-2@autosnap_2017-10-28_22:00:00_hourly
sanoid-test-2@autosnap_2017-10-28_23:00:00_hourly
sanoid-test-2@autosnap_2017-10-29_00:00:00_daily
sanoid-test-2@autosnap_2017-10-29_00:00:00_hourly
sanoid-test-2@autosnap_2017-10-29_01:00:00_hourly
sanoid-test-2@autosnap_2017-10-29_02:00:00_hourly
sanoid-test-2@autosnap_2017-10-29_02:00:00_y_hourly
sanoid-test-2@autosnap_2017-10-29_03:00:00_y_hourly
sanoid-test-2@autosnap_2017-10-29_04:00:00_y_hourly
sanoid-test-2@autosnap_2017-10-29_05:00:00_y_hourly
sanoid-test-2@autosnap_2017-10-29_06:00:00_y_hourly
sanoid-test-2@autosnap_2017-10-29_07:00:00_y_hourly
sanoid-test-2@autosnap_2017-10-29_08:00:00_y_hourly
sanoid-test-2@autosnap_2017-10-29_09:00:00_y_hourly
sanoid-test-2@autosnap_2017-10-29_10:00:00_y_hourly
sanoid-test-2@autosnap_2017-10-29_11:00:00_y_hourly
sanoid-test-2@autosnap_2017-10-29_12:00:00_y_hourly
sanoid-test-2@autosnap_2017-10-29_13:00:00_y_hourly
sanoid-test-2@autosnap_2017-10-29_14:00:00_y_hourly
sanoid-test-2@autosnap_2017-10-29_15:00:00_y_hourly
sanoid-test-2@autosnap_2017-10-29_16:00:00_y_hourly
sanoid-test-2@autosnap_2017-10-29_17:00:00_y_hourly
sanoid-test-2@autosnap_2017-10-29_18:00:00_y_hourly
sanoid-test-2@autosnap_2017-10-29_19:00:00_y_hourly
sanoid-test-2@autosnap_2017-10-29_20:00:00_y_hourly
sanoid-test-2@autosnap_2017-10-29_21:00:00_y_hourly
sanoid-test-2@autosnap_2017-10-29_22:00:00_y_hourly
sanoid-test-2@autosnap_2017-10-29_23:00:00_y_hourly
sanoid-test-2@autosnap_2017-10-30_00:00:00_daily
sanoid-test-2@autosnap_2017-10-30_00:00:00_hourly
sanoid-test-2@autosnap_2017-10-30_01:00:00_hourly
sanoid-test-2@autosnap_2017-10-30_02:00:00_hourly
sanoid-test-2@autosnap_2017-10-30_03:00:00_hourly
sanoid-test-2@autosnap_2017-10-30_04:00:00_hourly
sanoid-test-2@autosnap_2017-10-30_05:00:00_hourly
sanoid-test-2@autosnap_2017-10-30_06:00:00_hourly
sanoid-test-2@autosnap_2017-10-30_07:00:00_hourly
sanoid-test-2@autosnap_2017-10-30_08:00:00_hourly
sanoid-test-2@autosnap_2017-10-30_09:00:00_hourly
sanoid-test-2@autosnap_2017-10-30_10:00:00_hourly
sanoid-test-2@autosnap_2017-10-30_11:00:00_hourly
sanoid-test-2@autosnap_2017-10-30_12:00:00_hourly
sanoid-test-2@autosnap_2017-10-30_13:00:00_hourly
sanoid-test-2@autosnap_2017-10-30_14:00:00_hourly
sanoid-test-2@autosnap_2017-10-30_15:00:00_hourly
sanoid-test-2@autosnap_2017-10-30_16:00:00_hourly
sanoid-test-2@autosnap_2017-10-30_17:00:00_hourly
sanoid-test-2@autosnap_2017-10-30_18:00:00_hourly
sanoid-test-2@autosnap_2017-10-30_19:00:00_hourly
sanoid-test-2@autosnap_2017-10-30_20:00:00_hourly
sanoid-test-2@autosnap_2017-10-30_21:00:00_hourly
sanoid-test-2@autosnap_2017-10-30_22:00:00_hourly
sanoid-test-2@autosnap_2017-10-30_23:00:00_hourly

It also would be nicer to only use the suffix for the once duplicate hourly snapshot.

@phreaker0 phreaker0 mentioned this pull request Jun 5, 2018
Merged
@jimsalterjrs jimsalterjrs merged commit f107907 into jimsalterjrs:master Jun 28, 2018
@shodanshok shodanshok mentioned this pull request Jan 16, 2019
Closed
@shodanshok shodanshok mentioned this pull request Mar 26, 2019
Merged
@phreaker0 phreaker0 mentioned this pull request Jun 14, 2019
Merged
@phreaker0 phreaker0 deleted the dst-fixes branch March 24, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phreaker0 @jimsalterjrs