Spelling #788
Merged
Spelling #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
jsoref
commented
Jan 1, 2023
Comment on lines
-4
to
+5
| [syncoid] use sudo if neccessary for checking pool capabilities regarding resumeable send (@phreaker0) | ||
| [syncoid] catch another case were the resume state isn't availabe anymore (@phreaker0) | ||
| [syncoid] use sudo if necessary for checking pool capabilities regarding resumable send (@phreaker0) | ||
| [syncoid] catch another case were the resume state isn't available anymore (@phreaker0) |
There was a problem hiding this comment.
Some projects don't like changing changelogs. Happy to drop this or anything else.
| my $errorlevel = 0; | ||
| my $errlevel = 0; |
There was a problem hiding this comment.
Both forms are used in this file and there didn't seem to be any particular reason to use two different tokens for the same task. I personally would favor the longer form, but the shorter form was used more and feels more in keeping w/ the rest of the file/lines.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects misspellings identified by the check-spelling action.
The misspellings have been reported at https://github.com/jsoref/sanoid/actions/runs/3818601361#summary-10386815953
The action reports that the changes in this PR would make it happy: https://github.com/jsoref/sanoid/actions/runs/3818601388#summary-10386815994
Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.