PR Merger #807
Merged
PR Merger #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syncoid fails in the following case: - performing a stream sync (default) - there are no matching snapshots between source and target - there is a bookmark on the source matching a snapshot on the target - there is an unrelated snapshot on the source older than this bookmark This happens because the units for snapshots and bookmarks were different. syncoid tells `zfs send` to generate an incremental stream starting from the bookmark and going to the unrelated older snapshot. ZFS refuses to do this because it doesn't make sense. This fix is a bit of hack. Ideally we should share the counter code between getsnaps and getbookmarks.
…rinting a warning
- 11/24/2020 -> Tuesday - 12/04/2018 -> Tuesday Prior to changes: ``` $ rpmlint sanoid.spec sanoid.spec: E: specfile-error warning: bogus date in %changelog: Wed Nov 24 2020 Christoph Klaffl <christoph@phreaker.eu> - 2.1.0 sanoid.spec: E: specfile-error warning: bogus date in %changelog: Wed Dec 04 2018 Christoph Klaffl <christoph@phreaker.eu> - 2.0.0 0 packages and 1 specfiles checked; 2 errors, 0 warnings. ``` After changes: ``` $ rpmlint sanoid.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. ```
Installation information for running sanoid on MacOS via launchd. A launchd example plist file is provided in the same way equivalent files are created on other platforms.
Add requirement for syncoid w/ remote hosts to be able to sudo without a password. Recommends a least privilege configuration option for enabling `NOPASSWD`
Signed-off-by: Lilis Iskandar <lilis@veand.co>
Previous instructions couldn't actually be copied and pasted. This will update the instructions to work correctly when copied as-is
Updated the install language, and commands, to better server Centos 8 and it's derivatives. Instead of using CPAN, enabling the 'PowerTools' repo will make those modules available for installation and kept current with normal OS updates. Updated command to enable _and_ start sanoid.timer, instead of using two commands.
Add requirement for syncoid w/ remote hosts to be able to sudo without a password. Recommends a least privilege configuration option for enabling `NOPASSWD`
…t exist (and only skip child datasets which vanished)
Fixed some typos
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
|
Done! Thank you for the clean-up work. :) |
|
awesome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jimsalterjrs I've gone through the list of all open pull requests and merged all into this PR which are tested/documentation updates/fixes and are reasonable safe to merge to master for further testing. Merging will make it easier to go through the bigger PR's which needs testing/review and further enhancements.
Closes #506
Closes #538
Closes #592
Closes #605
Closes #606
Closes #608
Closes #636
Closes #637
Closes #638
Closes #643
Closes #657
Closes #670
Closes #679
Closes #690
Closes #701
Closes #765
Closes #766
Closes #767
Closes #768
Closes #769
Closes #775
Closes #788