Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ruby support for older versions #50

Closed
wants to merge 1 commit into from

Conversation

evanphx
Copy link

@evanphx evanphx commented Jun 5, 2011

Remove define_method with a block argument, that is only supported in 1.8.7+. Use class_eval instead.

@sferik
Copy link

sferik commented Jun 5, 2011

👍 Thanks for the quick fix, Evan.

I'm more generally concerned with how this was allowed to break in the first place. Is there a continuous integration server for Rake that runs the tests against Ruby 1.8.6? If not, may I recommend Travis?

@evanphx
Copy link
Author

evanphx commented Jun 5, 2011

I was too slow!

0e6587e

@evanphx evanphx closed this Jun 5, 2011
@jimweirich
Copy link
Owner

done

@drnic
Copy link

drnic commented Jun 5, 2011

Thanks guys!

@jimweirich
Copy link
Owner

evanphx ... thanks for the patch.

sferik ... Thanks for the bug report, and I might check out travis. I used RunCodeRun until they went defunct. Would like a new solution. Would LOVE a solution that included regression testing on windows.

@sferik
Copy link

sferik commented Jun 5, 2011

@jimweirich Thanks for the even quicker fix!

I know @drnic is also interested in regression testing on Windows (as am I). The three of us should really put our heads together on this one. The Travis team is currently busy working on system stability and getting the basic architecture in place. Setting up a Travis on Windows (or the Mac, to test MacRuby) should be trivial if we get the architecture right.

@sferik
Copy link

sferik commented Jun 5, 2011

I was also a big fan RunCodeRun before it went defunct. I think the main difference is that Travis is community supported instead of being tied to a single company's (mis)management. Travis will survive as long as it's valuable to the community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants