Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better monitoring #738

Merged
merged 4 commits into from
Jun 1, 2022
Merged

fix: better monitoring #738

merged 4 commits into from
Jun 1, 2022

Conversation

numb3r3
Copy link
Member

@numb3r3 numb3r3 commented Jun 1, 2022

Does not make sense to enable monitoring default, will remove monitoring from default YAML config. The monitoring port should be provided by the user depending on their environment in production.

@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #738 (ef11565) into main (751cf9d) will decrease coverage by 14.22%.
The diff coverage is 66.66%.

@@             Coverage Diff             @@
##             main     #738       +/-   ##
===========================================
- Coverage   80.91%   66.69%   -14.23%     
===========================================
  Files          16       16               
  Lines        1153     1171       +18     
===========================================
- Hits          933      781      -152     
- Misses        220      390      +170     
Flag Coverage Δ
cas 66.69% <66.66%> (-14.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/clip_server/executors/clip_tensorrt.py 0.00% <0.00%> (-92.86%) ⬇️
server/clip_server/executors/clip_onnx.py 85.71% <100.00%> (+1.20%) ⬆️
server/clip_server/executors/clip_torch.py 86.95% <100.00%> (+1.24%) ⬆️
server/clip_server/model/clip_trt.py 0.00% <0.00%> (-92.31%) ⬇️
server/clip_server/model/trt_utils.py 0.00% <0.00%> (-83.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 751cf9d...ef11565. Read the comment docs.

@numb3r3 numb3r3 changed the title fix: turn off monitor in default yaml config fix: better monitoring Jun 1, 2022
@github-actions github-actions bot added size/m and removed size/s labels Jun 1, 2022
@numb3r3 numb3r3 requested review from samsja and ZiniuYu June 1, 2022 03:52
Copy link
Contributor

@samsja samsja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mention in the documentation https://docs.jina.ai/fundamentals/executor/monitoring-executor/#defining-custom-metrics-with-monitor
To respect prometheus naming convention we need to add seconds at the end of the metrics

server/clip_server/executors/clip_onnx.py Outdated Show resolved Hide resolved
server/clip_server/executors/clip_onnx.py Outdated Show resolved Hide resolved
server/clip_server/executors/clip_onnx.py Outdated Show resolved Hide resolved
server/clip_server/executors/clip_onnx.py Outdated Show resolved Hide resolved
server/clip_server/executors/clip_tensorrt.py Outdated Show resolved Hide resolved
server/clip_server/executors/clip_tensorrt.py Outdated Show resolved Hide resolved
server/clip_server/executors/clip_torch.py Outdated Show resolved Hide resolved
server/clip_server/executors/clip_torch.py Outdated Show resolved Hide resolved
server/clip_server/executors/clip_torch.py Outdated Show resolved Hide resolved
server/clip_server/executors/clip_torch.py Outdated Show resolved Hide resolved
@numb3r3
Copy link
Member Author

numb3r3 commented Jun 1, 2022

@samsja Thanks for suggestions, have addressed them

@numb3r3 numb3r3 merged commit bb8c4ce into main Jun 1, 2022
@numb3r3 numb3r3 deleted the fix-flow-config branch June 1, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants