Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

feat: enhance AudioCLIPEncoder support #709

Merged
merged 6 commits into from Aug 28, 2021

Conversation

winstonww
Copy link
Contributor

@winstonww winstonww commented Aug 27, 2021

This PR:
- [x] adds a local AudioCLIPCrafter executor to adjust sample rate of audio before passing the blob to AudioCLIPEncoder for processing

  • Add clip option to test_audiio_to_audio_search.py

Thanks.

@winstonww
Copy link
Contributor Author

Removing AudioCLIPCrafter because sample rate adjustment should be done in AudioCLIPEncoder. It does not make much sense for AudioCLIPEnocder to process audio at a sample rate different from the target sample rate. Migrating this logic to AudioCLIPEncoder will safeguard users from providing audios with wrong sample rate.

Copy link
Member

@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nan-wang
Copy link
Member

Migrating this logic to AudioCLIPEncoder will safeguard users from providing audios with wrong sample rate.
Good point!

@nan-wang nan-wang merged commit c67e50a into master Aug 28, 2021
@nan-wang nan-wang deleted the feat-enhance-audio-clip-support branch August 28, 2021 15:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants