fix: remove dot from names (#519)

* fix: remove dot from names * fix: use dash to replace dot * chore: add changelog
jina-ai · Aug 31, 2022 · af67bdf · af67bdf
1 parent 829db26
commit af67bdf
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -24,6 +24,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
+- Replace the artifact name from dot to dash. ([#519](https://github.com/jina-ai/finetuner/pull/519))
+
 ### Docs
 
 - Fix google analytics Id for docs. ([#499](https://github.com/jina-ai/finetuner/pull/499))

diff --git a/finetuner/constants.py b/finetuner/constants.py
@@ -63,4 +63,4 @@
 OPTIONS = 'options'
 QUERY_DATA = 'query_data'
 INDEX_DATA = 'index_data'
-DA_PREFIX = 'finetuner.dastorage'
+DA_PREFIX = 'finetuner-dastorage'
diff --git a/finetuner/hubble.py b/finetuner/hubble.py
@@ -49,16 +49,16 @@ def _push_docarray(
     _ids2names = dict()
     return (
         _push_docarray(
-            train_data, f'{DA_PREFIX}.{experiment_name}.{run_name}.train', _ids2names
+            train_data, f'{DA_PREFIX}-{experiment_name}-{run_name}-train', _ids2names
         ),
         _push_docarray(
-            eval_data, f'{DA_PREFIX}.{experiment_name}.{run_name}.eval', _ids2names
+            eval_data, f'{DA_PREFIX}-{experiment_name}-{run_name}-eval', _ids2names
         ),
         _push_docarray(
-            query_data, f'{DA_PREFIX}.{experiment_name}.{run_name}.query', _ids2names
+            query_data, f'{DA_PREFIX}-{experiment_name}-{run_name}-query', _ids2names
         ),
         _push_docarray(
-            index_data, f'{DA_PREFIX}.{experiment_name}.{run_name}.index', _ids2names
+            index_data, f'{DA_PREFIX}-{experiment_name}-{run_name}-index', _ids2names
         ),
     )
 

diff --git a/tests/unit/test_experiment.py b/tests/unit/test_experiment.py
@@ -69,7 +69,7 @@ def test_list_runs(experiment):
 def test_create_run(experiment):
     data = docarray.DocumentArray().empty(1)
     run_name = 'run1'
-    data_name = f'{DA_PREFIX}.{experiment.name}.{run_name}.train'
+    data_name = f'{DA_PREFIX}-{experiment.name}-{run_name}-train'
     run = experiment.create_run(
         model='resnet50',
         model_options={},

diff --git a/tests/unit/test_hubble.py b/tests/unit/test_hubble.py
@@ -17,6 +17,6 @@ def test_push_data(client_mocker, experiment_name='exp', run_name='run'):
         query_data=query_data,
         index_data=index_data,
     )
-    assert train_name == f'{DA_PREFIX}.{experiment_name}.{run_name}.train'
-    assert eval_name == query_name == f'{DA_PREFIX}.{experiment_name}.{run_name}.eval'
+    assert train_name == f'{DA_PREFIX}-{experiment_name}-{run_name}-train'
+    assert eval_name == query_name == f'{DA_PREFIX}-{experiment_name}-{run_name}-eval'
     assert not index_name