Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove dot from names #519

Merged
merged 3 commits into from
Aug 31, 2022
Merged

fix: remove dot from names #519

merged 3 commits into from
Aug 31, 2022

Conversation

bwanglzu
Copy link
Member

@bwanglzu bwanglzu commented Aug 31, 2022 •
edited
Loading

Breaking change in hubble need a patch release asap.

https://github.com/jina-ai/hubble/issues/561

  • This PR references an open issue
  • I have added a line about this change to CHANGELOG

@github-actions github-actions bot added size/s area/testing This issue/PR affects testing and removed size/xs labels Aug 31, 2022
@bwanglzu bwanglzu marked this pull request as ready for review August 31, 2022 08:46
guenthermi
guenthermi approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@guenthermi guenthermi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bwanglzu bwanglzu merged commit af67bdf into main Aug 31, 2022
@bwanglzu bwanglzu deleted the fix-da-name branch August 31, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guenthermi guenthermi guenthermi approved these changes

@gmastrapas gmastrapas gmastrapas approved these changes

Assignees
No one assigned
Labels
area/core area/testing This issue/PR affects testing size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bwanglzu @guenthermi @gmastrapas