Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change helper function to private #151

Merged
merged 2 commits into from
Oct 19, 2021
Merged

fix: change helper function to private #151

merged 2 commits into from
Oct 19, 2021

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Oct 19, 2021

No description provided.

@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #151 (51d9713) into main (2916e9f) will not change coverage.
The diff coverage is 83.33%.

❗ Current head 51d9713 differs from pull request most recent head f1b06c9. Consider uploading reports for the commit f1b06c9 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #151   +/-   ##
=======================================
  Coverage   84.90%   84.90%           
=======================================
  Files          24       24           
  Lines        1166     1166           
=======================================
  Hits          990      990           
  Misses        176      176           
Flag Coverage Δ
finetuner 84.90% <83.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
finetuner/tuner/__init__.py 81.81% <66.66%> (ø)
finetuner/tailor/__init__.py 95.23% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 370e5fb...f1b06c9. Read the comment docs.

@github-actions github-actions bot added size/m and removed size/s labels Oct 19, 2021
@hanxiao hanxiao merged commit b951426 into main Oct 19, 2021
@hanxiao hanxiao deleted the fix-private-fn branch October 19, 2021 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant