Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add val_split to fit interface #624

Merged
merged 3 commits into from
Nov 29, 2022
Merged

feat: add val_split to fit interface #624

merged 3 commits into from
Nov 29, 2022

Conversation

guenthermi
Copy link
Member

@guenthermi guenthermi commented Nov 28, 2022

Add val_split to fit interface

This PR adds the val_split parameter introduced by https://github.com/jina-ai/finetuner-core/pull/401 to the fit function

Example usage:

def fit(
    model,
    train_data,,
    validation_split = 0.2
)

@guenthermi
Copy link
Member Author

I am not sure when to merge this. At the moment it will not work, since it requires a release of a new stubs version

@guenthermi guenthermi requested review from gmastrapas, bwanglzu and LMMilliken and removed request for gmastrapas and bwanglzu November 28, 2022 15:05
@guenthermi guenthermi merged commit 1f5c83e into main Nov 29, 2022
@guenthermi guenthermi deleted the feat-add-val-split branch November 29, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants