Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add val_split to fit interface #624

Merged
merged 3 commits into from
Nov 29, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Added

- Add `val_split` parameter to `fit` function. ([#624](https://github.com/jina-ai/finetuner/pull/624))

### Removed

### Changed
Expand Down
6 changes: 6 additions & 0 deletions finetuner/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ def fit(
model: str,
train_data: Union[str, TextIO, DocumentArray],
eval_data: Optional[Union[str, TextIO, DocumentArray]] = None,
val_split: float = 0.0,
run_name: Optional[str] = None,
description: Optional[str] = None,
experiment_name: Optional[str] = None,
Expand Down Expand Up @@ -147,6 +148,10 @@ def fit(
`DocumentArray` that is pushed on Jina AI Cloud or a path to a CSV file.
:param eval_data: Either a `DocumentArray` for evaluation data, a name of the
`DocumentArray` that is pushed on Jina AI Cloud or a path to a CSV file.
:param val_split: Determines which portion of the `train_data` is held out
for calculating a validation loss. If it is set to 0, or an `eval_data`
parameter is provided, no data is held out from the training data. Instead, the
`eval_data` is used to calculate the validation loss if it is provided.
:param run_name: Name of the run.
:param description: Run description.
:param experiment_name: Name of the experiment.
Expand Down Expand Up @@ -218,6 +223,7 @@ def fit(
model=model,
train_data=train_data,
eval_data=eval_data,
val_split=val_split,
run_name=run_name,
description=description,
experiment_name=experiment_name,
Expand Down
1 change: 1 addition & 0 deletions finetuner/constants.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,3 +69,4 @@
ONNX = 'to_onnx'
PUBLIC = 'public'
NUM_ITEMS_PER_CLASS = 'num_items_per_class'
VAL_SPLIT = 'val_split'
2 changes: 2 additions & 0 deletions finetuner/experiment.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
OUTPUT_DIM,
PUBLIC,
SCHEDULER_STEP,
VAL_SPLIT,
)
from finetuner.data import build_finetuning_dataset
from finetuner.hubble import push_data
Expand Down Expand Up @@ -247,6 +248,7 @@ def _create_config_for_run(
data = config.DataConfig(
train_data=train_data,
eval_data=kwargs.get(EVAL_DATA),
val_split=kwargs.get(VAL_SPLIT, 0.0),
num_items_per_class=kwargs.get(NUM_ITEMS_PER_CLASS, 4),
)
if kwargs.get(NUM_WORKERS):
Expand Down
2 changes: 2 additions & 0 deletions finetuner/finetuner.py
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ def create_run(
model: str,
train_data: Union[str, DocumentArray],
eval_data: Optional[Union[str, DocumentArray]] = None,
val_split: float = 0.0,
run_name: Optional[str] = None,
description: Optional[str] = None,
experiment_name: Optional[str] = None,
Expand Down Expand Up @@ -181,6 +182,7 @@ def create_run(
model=model,
train_data=train_data,
eval_data=eval_data,
val_split=val_split,
run_name=run_name,
description=description,
model_options=model_options or {},
Expand Down