-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: adopt api changes #637
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LMMilliken
approved these changes
Dec 14, 2022
gmastrapas
reviewed
Dec 14, 2022
Co-authored-by: George Mastrapas <32414777+gmastrapas@users.noreply.github.com>
Co-authored-by: George Mastrapas <32414777+gmastrapas@users.noreply.github.com>
Co-authored-by: George Mastrapas <32414777+gmastrapas@users.noreply.github.com>
Co-authored-by: George Mastrapas <32414777+gmastrapas@users.noreply.github.com>
Co-authored-by: George Mastrapas <32414777+gmastrapas@users.noreply.github.com>
guenthermi
requested changes
Dec 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments
gmastrapas
approved these changes
Dec 14, 2022
guenthermi
approved these changes
Dec 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some minor comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to our recent API changes (mostly paginated results), the staging env for integration test is not working anymore. In this PR the changes has been adopted, also added an extra parameter
size=50
to allow user set return number.experiment_name
asdefault
.full-trace
from pytest to make github actions error messages easier to read.