Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: adopt api changes #637

Merged
merged 20 commits into from
Dec 14, 2022
Merged

refactor: adopt api changes #637

merged 20 commits into from
Dec 14, 2022

Conversation

bwanglzu
Copy link
Member

@bwanglzu bwanglzu commented Dec 14, 2022

Due to our recent API changes (mostly paginated results), the staging env for integration test is not working anymore. In this PR the changes has been adopted, also added an extra parameter size=50 to allow user set return number.

  1. Update all endpoints based on recent API changes.
  2. Change default experiment_name as default.
  3. Remove full-trace from pytest to make github actions error messages easier to read.

  • This PR references an open issue
  • I have added a line about this change to CHANGELOG

@bwanglzu bwanglzu changed the title Refactor adopt api changes refactor: adopt api changes Dec 14, 2022
@bwanglzu bwanglzu marked this pull request as ready for review December 14, 2022 04:43
@bwanglzu bwanglzu self-assigned this Dec 14, 2022
finetuner/__init__.py Show resolved Hide resolved
finetuner/client/client.py Outdated Show resolved Hide resolved
finetuner/client/client.py Outdated Show resolved Hide resolved
finetuner/client/client.py Outdated Show resolved Hide resolved
finetuner/client/client.py Outdated Show resolved Hide resolved
finetuner/client/client.py Outdated Show resolved Hide resolved
bwanglzu and others added 5 commits December 14, 2022 10:55
Co-authored-by: George Mastrapas <32414777+gmastrapas@users.noreply.github.com>
Co-authored-by: George Mastrapas <32414777+gmastrapas@users.noreply.github.com>
Co-authored-by: George Mastrapas <32414777+gmastrapas@users.noreply.github.com>
Co-authored-by: George Mastrapas <32414777+gmastrapas@users.noreply.github.com>
Co-authored-by: George Mastrapas <32414777+gmastrapas@users.noreply.github.com>
Copy link
Member

@guenthermi guenthermi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments

finetuner/__init__.py Show resolved Hide resolved
finetuner/__init__.py Outdated Show resolved Hide resolved
finetuner/client/client.py Outdated Show resolved Hide resolved
finetuner/client/client.py Outdated Show resolved Hide resolved
Copy link
Member

@guenthermi guenthermi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some minor comments

finetuner/client/client.py Outdated Show resolved Hide resolved
finetuner/client/client.py Outdated Show resolved Hide resolved
@bwanglzu bwanglzu merged commit c81dcff into main Dec 14, 2022
@bwanglzu bwanglzu deleted the refactor-adopt-api-changes branch December 14, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants