Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tailor): improve interface #82

Merged
merged 12 commits into from
Oct 5, 2021
Merged

refactor(tailor): improve interface #82

merged 12 commits into from
Oct 5, 2021

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Oct 4, 2021

No description provided.

@bwanglzu
Copy link
Member

bwanglzu commented Oct 5, 2021 •
edited
Loading

what has been done in this PR?

  1. api change, user provide name instead of idx.
  2. adjust unit tests
  3. now pytorch embedding_layer_name has changed from Class-Number to class_number.

How embedding_layer_name looks different between pytorch and paddle?

  1. paddle has built-in layer _full_name, while pytorch not. Paddle layer name starts from 0, in pytorch we start from 1
  2. paddle [layer_name]_[idx], the idx increase 1 with respect to the same layer_name, e.g. linear_0, relu_0, linear_1, while pytroch looks like this: linear_1, relu_2, linear_3.

@hanxiao hanxiao merged commit 91587d8 into main Oct 5, 2021
@hanxiao hanxiao deleted the refactor-tailor branch October 5, 2021 13:19
@bwanglzu bwanglzu mentioned this pull request Oct 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoanFM JoanFM Awaiting requested review from JoanFM

@maximilianwerk maximilianwerk Awaiting requested review from maximilianwerk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hanxiao @bwanglzu