Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(tailor): add test for name is none #87

Merged
merged 3 commits into from
Oct 6, 2021

Conversation

bwanglzu
Copy link
Member

@bwanglzu bwanglzu commented Oct 5, 2021

  1. add tailor tests when user didn't specify a embedding_layer_name, we use the last layer as the feature extractor.
  2. fix an issue in pytorch where last layer is the model itself. For instance, last layer of vgg16 has 2 dimensional outputs, so it was added into the embedding_layers. If user didn't specify an embedding_layer_name, the entire vgg model will be replaced with Identity.

note: after previous refactoring #82 , keras 's tailor behaviour started to different from paddle and torch. When use last layer as embedding_layer, keras will take the last layer while paddle and torch will replace the last layer is Identity.

@bwanglzu bwanglzu marked this pull request as ready for review October 5, 2021 14:28
@bwanglzu bwanglzu changed the title test(tailor): ignore class itself from embedding layers and add test for name is none test(tailor): add test for name is none Oct 5, 2021
@bwanglzu bwanglzu requested a review from tadejsv October 5, 2021 17:20
@hanxiao hanxiao merged commit 47b7a55 into main Oct 6, 2021
@hanxiao hanxiao deleted the test-tailor-empty-embedding-name branch October 6, 2021 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants