Skip to content

Commit

Permalink
Merge branch 'master' into fix-doccache-backwards
Browse files Browse the repository at this point in the history
  • Loading branch information
cristianmtr committed Feb 24, 2021
2 parents cb60e93 + 810d71a commit 231bd82
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 223 deletions.
174 changes: 0 additions & 174 deletions jina/executors/clients.py

This file was deleted.

47 changes: 0 additions & 47 deletions jina/executors/encoders/tfserving.py

This file was deleted.

7 changes: 5 additions & 2 deletions jina/executors/indexers/cache.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import pickle
import tempfile
from typing import Optional, Iterable, List, Tuple
from typing import Optional, Iterable, List, Tuple, Union

from jina.executors.indexers import BaseKVIndexer
from jina.helper import deprecated_alias
Expand Down Expand Up @@ -73,7 +73,10 @@ def close(self):
default_fields = (ID_KEY,)

@deprecated_alias(field=('fields', 0))
def __init__(self, index_filename: Optional[str] = None, fields: Optional[Tuple[str]] = None, *args, **kwargs):
def __init__(self,
index_filename: Optional[str] = None,
fields: Optional[Union[str, Tuple[str]]] = None, # str for backwards compatibility
*args, **kwargs):
if not index_filename:
# create a new temp file if not exist
index_filename = tempfile.NamedTemporaryFile(delete=False).name
Expand Down

0 comments on commit 231bd82

Please sign in to comment.