Skip to content

Commit

Permalink
fix: dont test thread backend in jinad (#4148)
Browse files Browse the repository at this point in the history
  • Loading branch information
jacobowitz committed Jan 10, 2022
1 parent 0d0e180 commit 4c6e393
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
5 changes: 2 additions & 3 deletions tests/distributed/test_remote_peas/test_remote_peas.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,8 @@ def test_jinad_process_target(worker_cls, event, pea_args):
assert not is_pea_ready(pea_args)


@pytest.mark.parametrize('runtime_backend', ['PROCESS', 'THREAD'])
def test_jinad_pea(runtime_backend):
args = set_pea_parser().parse_args(['--runtime-backend', runtime_backend])
def test_jinad_pea():
args = set_pea_parser().parse_args([])
assert not is_pea_ready(args)

with JinaDPea(args):
Expand Down
5 changes: 2 additions & 3 deletions tests/unit/peapods/peas/test_jinad.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,12 @@ def mock_is_ready(*args):
@pytest.mark.skip(
"Does not work for some reason, should be reenabled when jinad is properly implemented"
)
@pytest.mark.parametrize('runtime_backend', ['PROCESS', 'THREAD'])
def test_events(monkeypatch, runtime_backend):
def test_events(monkeypatch):
monkeypatch.setattr(JinaDProcessTarget, '_create_remote_pea', mock_sleep)
monkeypatch.setattr(JinaDProcessTarget, '_terminate_remote_pea', mock_sleep)
monkeypatch.setattr(JinaDProcessTarget, '_stream_logs', mock_sleep)
monkeypatch.setattr(jinad, 'is_ready', mock_is_ready)
args = set_pea_parser().parse_args(['--runtime-backend', runtime_backend])
args = set_pea_parser().parse_args([])

pea = JinaDPea(args)
assert not pea.is_started.is_set()
Expand Down

0 comments on commit 4c6e393

Please sign in to comment.