-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
freeze the requirement versions before jina hub build
#1378
Comments
Hello @hanxiao . Can you please elaborate this issue? I'd like to contribute. Thank you! |
@StutiV Good to hear you would like to contribute! 🥳🥳🥳 |
This issue is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 4 days |
resolved by #1587 |
Not solved until hub_builer uses proper image. Right now when opening a PR to hub, the version not yet published is used and thus no jina pip package found |
The new version is now published. https://github.com/jina-ai/action-hub-builder/releases/tag/v0.8 |
Describe the feature
originally from @florian-hoenicke : https://jinaai.slack.com/archives/C018QC78L84/p1606762818107400
For the sake of deterministic builds it would make sense to me if we always have fixed versions. What do you think?
Example
->
Your proposal
add the
freeze
logic to here https://github.com/jina-ai/jina/blob/master/jina/docker/hubio.py#L303should be a quick work, the logic is:
jina hub build xxx
requirements.txt
to that freezer version, old namedrequirements.old
requirments.txt
requirements.old
to.txt
to users.@cristianmtr may also related
Environment
Screenshots
The text was updated successfully, but these errors were encountered: