Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freeze the requirement versions before jina hub build #1378

Closed
hanxiao opened this issue Nov 30, 2020 · 6 comments · Fixed by #1587
Closed

freeze the requirement versions before jina hub build #1378

hanxiao opened this issue Nov 30, 2020 · 6 comments · Fixed by #1587
Assignees
Labels
good first issue Good for newcomers type/feature-request This issue describes a new feature or behaviour a user or users desires.

Comments

@hanxiao
Copy link
Member

hanxiao commented Nov 30, 2020

Describe the feature

originally from @florian-hoenicke : https://jinaai.slack.com/archives/C018QC78L84/p1606762818107400

For the sake of deterministic builds it would make sense to me if we always have fixed versions. What do you think?
Example

TransformerTorchEncoder
transformers>=3.0.0
torch>=1.6.0
jina

->

transformers==3.5.1
torch==1.7.0
jina==0.8.2

Your proposal

add the freeze logic to here https://github.com/jina-ai/jina/blob/master/jina/docker/hubio.py#L303

should be a quick work, the logic is:

  1. determining the freezed requirement at jina hub build xxx
  2. update requirements.txt to that freezer version, old named requirements.old
  3. proceed the build with new requirments.txt
  4. all things done, restore requirements.old to .txt to users.

@cristianmtr may also related


Environment

Screenshots

@hanxiao hanxiao added good first issue Good for newcomers type/feature-request This issue describes a new feature or behaviour a user or users desires. labels Nov 30, 2020
@StutiV
Copy link

StutiV commented Dec 11, 2020

Hello @hanxiao . Can you please elaborate this issue? I'd like to contribute. Thank you!

@florian-hoenicke
Copy link
Member

@StutiV Good to hear you would like to contribute! 🥳🥳🥳
As a first step, you could update the hub components and fix the version numbers to the latest working version.
Implementing this automation in our build pipeline might be a bit too difficult when you are new to Jina.

@jina-bot
Copy link
Member

jina-bot commented Jan 5, 2021

This issue is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 4 days

@nan-wang
Copy link
Member

nan-wang commented Jan 6, 2021

resolved by #1587

@nan-wang nan-wang closed this as completed Jan 6, 2021
@JoanFM JoanFM reopened this Jan 6, 2021
@JoanFM
Copy link
Member

JoanFM commented Jan 6, 2021

Not solved until hub_builer uses proper image. Right now when opening a PR to hub, the version not yet published is used and thus no jina pip package found

@nan-wang
Copy link
Member

nan-wang commented Jan 7, 2021

The new version is now published. https://github.com/jina-ai/action-hub-builder/releases/tag/v0.8

@nan-wang nan-wang closed this as completed Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type/feature-request This issue describes a new feature or behaviour a user or users desires.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants