Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: freeze jina version in hub build #1587

Merged
merged 1 commit into from Jan 5, 2021
Merged

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Jan 4, 2021

Changes introduced
Freeze jina version to the core version that builds the hub image

resolved #1378

@JoanFM JoanFM requested a review from a team as a code owner January 4, 2021 17:36
@JoanFM JoanFM requested review from yuanbit and FionnD January 4, 2021 17:36
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase component/docker labels Jan 4, 2021
@github-actions
Copy link

github-actions bot commented Jan 4, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1695, delta to last 3 avg.: +0%
  • 😶 query QPS at 31, delta to last 3 avg.: -3%

Breakdown

Version Index QPS Query QPS
current 1695 31
0.9.1 1699 32
0.8.22 1703 31
0.8.21 1700 32

Backed by latency-tracking. Further commits will update this comment.

Copy link
Member

@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍 Maybe we can add a unit test?

@JoanFM
Copy link
Member Author

JoanFM commented Jan 5, 2021

@nan-wang does not this conflict with ur PR in action builder?

jina/docker/hubio.py Outdated Show resolved Hide resolved
@nan-wang
Copy link
Member

nan-wang commented Jan 5, 2021

@nan-wang does not this conflict with ur PR in action builder?

Nope. This is consistent with current behaviors. The hub-builder calls hubio for building the image and therefore the jina_version depends on which base image is used.

However, your concern is valid. The Jina versions used in hub-updater and hub-builder are implicitly coupled.

@jina-bot jina-bot added the area/testing This issue/PR affects testing label Jan 5, 2021
@JoanFM JoanFM requested a review from nan-wang January 5, 2021 13:35
@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #1587 (3b27e6b) into master (35139e9) will increase coverage by 1.36%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1587      +/-   ##
==========================================
+ Coverage   83.44%   84.80%   +1.36%     
==========================================
  Files         128      128              
  Lines        6646     6721      +75     
==========================================
+ Hits         5546     5700     +154     
+ Misses       1100     1021      -79     
Impacted Files Coverage Δ
jina/docker/checker.py 82.14% <ø> (ø)
jina/docker/hubio.py 73.10% <100.00%> (+11.46%) ⬆️
jina/logging/profile.py 69.84% <0.00%> (-0.56%) ⬇️
jina/drivers/craft.py 100.00% <0.00%> (ø)
jina/types/ndarray/generic.py 100.00% <0.00%> (ø)
jina/drivers/encode.py 94.91% <0.00%> (+0.08%) ⬆️
jina/enums.py 96.59% <0.00%> (+0.09%) ⬆️
jina/jaml/__init__.py 95.93% <0.00%> (+0.09%) ⬆️
jina/clients/helper.py 94.00% <0.00%> (+0.12%) ⬆️
jina/peapods/runtimes/asyncio/rest/__init__.py 93.18% <0.00%> (+0.15%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35139e9...3b27e6b. Read the comment docs.

Copy link
Member

@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nan-wang nan-wang merged commit 93024f7 into master Jan 5, 2021
@nan-wang nan-wang deleted the freeze-jina-version-hub branch January 5, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/docker size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

freeze the requirement versions before jina hub build
3 participants