New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: freeze jina version in hub build #1587
Conversation
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
0a73c8c
to
0cb7b03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍 Maybe we can add a unit test?
@nan-wang does not this conflict with ur PR in action builder? |
Nope. This is consistent with current behaviors. The hub-builder calls However, your concern is valid. The Jina versions used in hub-updater and hub-builder are implicitly coupled. |
0cb7b03
to
3b27e6b
Compare
Codecov Report
@@ Coverage Diff @@
## master #1587 +/- ##
==========================================
+ Coverage 83.44% 84.80% +1.36%
==========================================
Files 128 128
Lines 6646 6721 +75
==========================================
+ Hits 5546 5700 +154
+ Misses 1100 1021 -79
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍
Changes introduced
Freeze jina version to the core version that builds the hub image
resolved #1378