Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor match parent method #2161

Closed
florian-hoenicke opened this issue Mar 12, 2021 · 0 comments · Fixed by #2159
Closed

refactor match parent method #2161

florian-hoenicke opened this issue Mar 12, 2021 · 0 comments · Fixed by #2159
Assignees
@florian-hoenicke
Labels
area/core This issue/PR affects the core codebase status/done This issue is complete. type/maintenance This issue is not a bug or a feature_request.

Comments

@florian-hoenicke
Copy link
Member

The parent class had a different function interface compared to the overridden method.
@florian-hoenicke florian-hoenicke self-assigned this Mar 12, 2021
@florian-hoenicke florian-hoenicke linked a pull request Mar 12, 2021 that will close this issue
refactor: match parent method #2159
Merged
@florian-hoenicke florian-hoenicke mentioned this issue Mar 12, 2021
Merged
@FionnD FionnD added area/core This issue/PR affects the core codebase status/in-progess This issue is activity being worked on. type/maintenance This issue is not a bug or a feature_request. labels Mar 12, 2021
@FionnD FionnD added status/done This issue is complete. and removed status/in-progess This issue is activity being worked on. labels Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@florian-hoenicke florian-hoenicke

Labels
area/core This issue/PR affects the core codebase status/done This issue is complete. type/maintenance This issue is not a bug or a feature_request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: match parent method jina-ai/jina
2 participants
@florian-hoenicke @FionnD