Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: match parent method #2159

Merged
merged 1 commit into from Mar 12, 2021
Merged

Conversation

florian-hoenicke
Copy link
Member

@florian-hoenicke florian-hoenicke commented Mar 11, 2021

The parent class had a different function interface compared to the overridden method.
resolves #2161

@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #2159 (004d9f0) into master (77b222a) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2159      +/-   ##
==========================================
- Coverage   90.54%   90.39%   -0.16%     
==========================================
  Files         211      211              
  Lines       11216    11216              
==========================================
- Hits        10156    10139      -17     
- Misses       1060     1077      +17     
Flag Coverage Δ
daemon 50.37% <50.00%> (ø)
jina 90.85% <100.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/executors/indexers/keyvalue.py 98.37% <100.00%> (ø)
jina/types/document/multimodal.py 96.29% <100.00%> (ø)
jina/peapods/runtimes/jinad/client.py 82.48% <0.00%> (-5.11%) ⬇️
jina/clients/base.py 80.83% <0.00%> (-2.50%) ⬇️
jina/peapods/zmq/__init__.py 79.87% <0.00%> (-2.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77b222a...004d9f0. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1068, delta to last 3 avg.: +0%
  • 😶 query QPS at 18, delta to last 3 avg.: +0%

Breakdown

Version Index QPS Query QPS
current 1068 18
1.0.8 1058 17
1.0.7 1081 18

Backed by latency-tracking. Further commits will update this comment.

@florian-hoenicke florian-hoenicke linked an issue Mar 12, 2021 that may be closed by this pull request
Copy link
Member

@maximilianwerk maximilianwerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@florian-hoenicke florian-hoenicke merged commit 9cbf6bd into master Mar 12, 2021
@florian-hoenicke florian-hoenicke deleted the refactor-match-parent-method branch March 12, 2021 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor match parent method
3 participants