New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

type hint is wrong for crafter due to recent changes on batching #2175

Closed

hanxiao opened this issue Mar 16, 2021 · 1 comment · Fixed by #2196

Member

hanxiao commented Mar 16, 2021

jina/jina/executors/crafters/__init__.py

Line 39 in b3550e9

def craft(self, *args, **kwargs) -> Dict:

recent PR made crafter works in batch (only), so the signature of return Dict above has to be changed

Member

JoanFM commented Mar 16, 2021

Same happens for Segmenter.

JoanFM linked a pull request

that will close this issue

refactor: refactor signatures after batching adaptation #2196

Merged

hanxiao closed this as completed in #2196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment