Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor signatures after batching adaptation #2196

Merged
merged 1 commit into from Mar 17, 2021

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Mar 17, 2021

No description provided.

@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #2196 (3a97e7b) into master (abceba0) will increase coverage by 3.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2196      +/-   ##
==========================================
+ Coverage   87.54%   90.56%   +3.02%     
==========================================
  Files         208      208              
  Lines       11222    11222              
==========================================
+ Hits         9824    10163     +339     
+ Misses       1398     1059     -339     
Flag Coverage Δ
daemon 50.24% <100.00%> (-28.32%) ⬇️
jina 91.02% <100.00%> (+3.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/executors/crafters/__init__.py 100.00% <100.00%> (ø)
jina/executors/rankers/__init__.py 100.00% <100.00%> (ø)
jina/executors/segmenters/__init__.py 92.30% <100.00%> (ø)
jina/executors/compound.py 89.31% <0.00%> (+1.52%) ⬆️
jina/jaml/helper.py 93.89% <0.00%> (+2.29%) ⬆️
jina/clients/base.py 83.33% <0.00%> (+2.50%) ⬆️
jina/peapods/zmq/__init__.py 82.01% <0.00%> (+2.74%) ⬆️
jina/jaml/__init__.py 96.25% <0.00%> (+4.27%) ⬆️
jina/drivers/control.py 95.00% <0.00%> (+5.00%) ⬆️
jina/types/request/__init__.py 99.21% <0.00%> (+6.29%) ⬆️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abceba0...3a97e7b. Read the comment docs.

@JoanFM JoanFM linked an issue Mar 17, 2021 that may be closed by this pull request
@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1220, delta to last 3 avg.: +0%
  • 😶 query QPS at 20, delta to last 3 avg.: +0%

Breakdown

Version Index QPS Query QPS
current 1220 20
1.0.9 1216 20

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 0308fd7 into master Mar 17, 2021
@hanxiao hanxiao deleted the fix-signatures branch March 17, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

type hint is wrong for crafter due to recent changes on batching
3 participants