-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression test for all three hello-world demos #2193
Comments
Example for multimodal can be taken from reverted change in #2178. It was reverted for other reasons, but the test would still be valid |
glad to work on it with other engineers. |
Multimodal helloworld has already been added, please add the other integration tests in the same subfolders |
One thing to be aware of. Adding these tests, make the tests dependant on the |
@bwanglzu can u make sure the helloworld examples tests are moved to their own folder independent of integration tests? Like this we can easily skip it when necessary much easier |
@JoanFM I will |
Describe the feature
hello-world examples are important, if it breaks for a first-time user, then we lose this user.
The current tests on hello-world is not enough, it does not check (1) if index/search is successful (2) the sanity of retrieved results.
Your proposal
Please add regression test for three hello-world.
Environment
Screenshots
Tasks:
The text was updated successfully, but these errors were encountered: