Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix multimodal example #2178

Merged
merged 6 commits into from
Mar 17, 2021
Merged

fix: fix multimodal example #2178

merged 6 commits into from
Mar 17, 2021

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Mar 16, 2021 •
edited

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner March 16, 2021 11:39
@JoanFM JoanFM marked this pull request as draft March 16, 2021 11:39
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase component/resource component/type labels Mar 16, 2021
@github-actions
Copy link

github-actions bot commented Mar 16, 2021 •
edited

Latency summary

Current PR yields:

  • 😶 index QPS at 1017, delta to last 3 avg.: +3%
  • 😶 query QPS at 14, delta to last 3 avg.: -3%

Breakdown

Version Index QPS Query QPS
current 1017 14
1.0.10 1001 14
1.0.9 972 14

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link

codecov bot commented Mar 16, 2021 •
edited

Codecov Report

Merging #2178 (1d223c5) into master (3bf8c15) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2178      +/-   ##
==========================================
+ Coverage   90.41%   90.51%   +0.10%     
==========================================
  Files         208      208              
  Lines       11243    11243              
==========================================
+ Hits        10165    10177      +12     
+ Misses       1078     1066      -12
Flag Coverage Δ
daemon 50.20% <0.00%> (ø)
jina 90.98% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/types/sets/document.py 94.73% <100.00%> (ø)
jina/types/document/__init__.py 91.89% <0.00%> (-0.26%) ⬇️
jina/peapods/runtimes/zmq/zed.py 92.90% <0.00%> (+1.41%) ⬆️
jina/peapods/zmq/__init__.py 82.01% <0.00%> (+2.13%) ⬆️
jina/clients/base.py 83.33% <0.00%> (+2.50%) ⬆️
jina/drivers/segment.py 78.78% <0.00%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bf8c15...1d223c5. Read the comment docs.

@jina-bot jina-bot added size/M area/testing This issue/PR affects testing and removed size/S labels Mar 16, 2021
@JoanFM JoanFM linked an issue Mar 16, 2021 that may be closed by this pull request
jina helloworld multimodal broken after batching changes #2176
Closed
Yongxuanzhang
Yongxuanzhang reviewed Mar 16, 2021
View reviewed changes
jina/resources/multimodal/pods/segmenter.py
@@ -22,6 +24,7 @@ def craft(self, tags):
class BiSegmenter(Segmenter):
"""Segmenter for multimodal example."""

@single_multi_input(num_data=2, flatten_output=False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This setting increases the learning time for developers. They not only need to learn which exec to choose, but also determine how to decorate the method.
Is it possible to maintain the previous code and behavior, and we only add these decorators when needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to do so, but the cost for this would mean having an extra set of Drivers, (with an explosion of Drivers).

One thing I wanted to do was to see if we can add the decorators automatically.

But yes, it is a problem from this point of view.

What can we do about this @nan-wang ?

This was referenced Mar 16, 2021
Merged
Merged
@JoanFM JoanFM marked this pull request as ready for review March 16, 2021 16:48
@JoanFM JoanFM mentioned this pull request Mar 16, 2021
Closed
@Yongxuanzhang
Copy link
Contributor

Shall we merge this?

@hanxiao hanxiao merged commit 8849200 into master Mar 17, 2021
@hanxiao hanxiao deleted the fix-multimodal-seg branch March 17, 2021 00:21
@hanxiao
Copy link
Member

hanxiao commented Mar 17, 2021

reject. as stack_contents is unnecessary

hanxiao added a commit that referenced this pull request Mar 17, 2021
@hanxiao
Revert "fix: fix multimodal example (#2178)"
dd1cbc5 
This reverts commit 8849200.
@hanxiao hanxiao mentioned this pull request Mar 17, 2021
Merged
hanxiao added a commit that referenced this pull request Mar 17, 2021
@hanxiao
Revert "fix: fix multimodal example (#2178)" (#2191)
44e6e91 
This reverts commit 8849200.
@JoanFM JoanFM mentioned this pull request Mar 17, 2021
Closed
4 tasks
@JoanFM
Copy link
Member Author

JoanFM commented Mar 17, 2021

reject. as stack_contents is unnecessary

How will it be handled then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yongxuanzhang Yongxuanzhang Yongxuanzhang approved these changes

@Kelton8Z Kelton8Z Awaiting requested review from Kelton8Z

@nan-wang nan-wang Awaiting requested review from nan-wang

@florian-hoenicke florian-hoenicke Awaiting requested review from florian-hoenicke

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/resource component/type size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jina helloworld multimodal broken after batching changes
4 participants
@JoanFM @Yongxuanzhang @hanxiao @jina-bot