Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor queryset with primitive type #1336

Merged
merged 2 commits into from
Nov 23, 2020
Merged

Conversation

bwanglzu
Copy link
Member

@bwanglzu bwanglzu commented Nov 23, 2020

Refactor queryset unittest with new api and document type. #1329

@bwanglzu bwanglzu self-assigned this Nov 23, 2020
@bwanglzu bwanglzu requested a review from a team as a code owner November 23, 2020 22:39
@bwanglzu bwanglzu requested review from maximilianwerk and imsergiy and removed request for imsergiy November 23, 2020 22:39
@jina-bot jina-bot added size/S area/testing This issue/PR affects testing labels Nov 23, 2020
@codecov
Copy link

codecov bot commented Nov 23, 2020

Codecov Report

Merging #1336 (db5f3dc) into master (42f9919) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1336      +/-   ##
==========================================
+ Coverage   83.35%   83.40%   +0.04%     
==========================================
  Files         101      101              
  Lines        6706     6706              
==========================================
+ Hits         5590     5593       +3     
+ Misses       1116     1113       -3     
Impacted Files Coverage Δ
jina/peapods/grpc_asyncio.py 75.51% <0.00%> (-1.03%) ⬇️
jina/logging/sse.py 95.16% <0.00%> (+3.22%) ⬆️
jina/drivers/querylang/select.py 86.20% <0.00%> (+6.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42f9919...ca89d3b. Read the comment docs.

@jina-bot jina-bot merged commit ca89d3b into master Nov 23, 2020
@jina-bot jina-bot deleted the test-refactor-queryset branch November 23, 2020 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing This issue/PR affects testing size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants