New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(flow): no constructor for class method needed #1352
chore(flow): no constructor for class method needed #1352
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1352 +/- ##
==========================================
+ Coverage 82.87% 82.93% +0.05%
==========================================
Files 103 103
Lines 6746 6746
==========================================
+ Hits 5591 5595 +4
+ Misses 1155 1151 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
Nice, but then should't it be a |
yes, u are right, it should be a static |
@florian-hoenicke Good job! A minor comment. |
correct: skip our cd not skip unit test |
@nan-wang Thanks, I will use refactor in the future. |
Since
load_config
is aclassmethod
, we don't need to call it on a Flow object. Instead we can call theclassmethod
directly.