Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove hub updater #1360

Merged
merged 1 commit into from Nov 26, 2020
Merged

ci: remove hub updater #1360

merged 1 commit into from Nov 26, 2020

Conversation

cristianmtr
Copy link
Contributor

  • Remove updater script
  • Remove workflow for updating Hub

These are now both part of the Hub, see PR jina-ai/jina-hub#1180

@cristianmtr cristianmtr requested review from hanxiao and a team as code owners November 26, 2020 09:27
@jina-bot jina-bot added size/M area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Nov 26, 2020
@codecov
Copy link

codecov bot commented Nov 26, 2020

Codecov Report

Merging #1360 (c8424fd) into master (e122348) will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1360      +/-   ##
==========================================
+ Coverage   82.89%   83.10%   +0.21%     
==========================================
  Files         103      103              
  Lines        6746     6814      +68     
==========================================
+ Hits         5592     5663      +71     
+ Misses       1154     1151       -3     
Impacted Files Coverage Δ
jina/drivers/querylang/select.py 79.31% <0.00%> (-6.90%) ⬇️
jina/logging/profile.py 55.81% <0.00%> (-0.66%) ⬇️
jina/peapods/pod.py 82.89% <0.00%> (-0.10%) ⬇️
jina/drivers/craft.py 100.00% <0.00%> (ø)
jina/types/ndarray/generic.py 100.00% <0.00%> (ø)
jina/executors/indexers/cache.py 100.00% <0.00%> (ø)
jina/executors/evaluators/text/length.py 100.00% <0.00%> (ø)
jina/executors/evaluators/rank/precision.py 100.00% <0.00%> (ø)
jina/types/document/__init__.py 96.87% <0.00%> (+0.01%) ⬆️
jina/drivers/evaluate.py 98.21% <0.00%> (+0.03%) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f13559...c8424fd. Read the comment docs.

Copy link
Contributor

@rutujasurve94 rutujasurve94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can retrigger jinad test to confirm it doesn't fail

@cristianmtr
Copy link
Contributor Author

LGTM, we can retrigger jinad test to confirm it doesn't fail

Seems like it failed again. Can't grasp why. I'm seeing something about curl empty response

@JoanFM
Copy link
Member

JoanFM commented Nov 26, 2020

LGTM, we can retrigger jinad test to confirm it doesn't fail

Seems like it failed again. Can't grasp why. I'm seeing something about curl empty response

It is not requested, u can go on ignoring them for now

@hanxiao hanxiao merged commit 2d3f69b into master Nov 26, 2020
@hanxiao hanxiao deleted the ci-remove-updater branch November 26, 2020 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants