Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(readme): update korean readme #1364

Merged
merged 1 commit into from Nov 26, 2020
Merged

fix(readme): update korean readme #1364

merged 1 commit into from Nov 26, 2020

Conversation

doomdabo
Copy link
Contributor

This is another account of rabbits99 team. Sorry for making confuse again.
This file is new version of readme-korean.

I hope that it works well.
Thank you

I have read the CLA Document and I hereby sign the CLA

This is another account of rabbits99 team. Sorry for making confuse again.
This file is new version of readme-korean.

I hope that it works well. 
Thank you

I have read the CLA Document and I hereby sign the CLA
@jina-bot jina-bot added size/M area/housekeeping This issue/PR is housekeeping labels Nov 26, 2020
@doomdabo
Copy link
Contributor Author

what is the matter of "Issue Ref PR"?,,,

@codecov
Copy link

codecov bot commented Nov 26, 2020

Codecov Report

Merging #1364 (8d72752) into master (ed81dd3) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1364      +/-   ##
==========================================
- Coverage   82.90%   82.87%   -0.03%     
==========================================
  Files         103      103              
  Lines        6746     6746              
==========================================
- Hits         5593     5591       -2     
- Misses       1153     1155       +2     
Impacted Files Coverage Δ
jina/logging/sse.py 91.93% <0.00%> (-3.23%) ⬇️
jina/docker/hubio.py 64.85% <0.00%> (-0.86%) ⬇️
jina/peapods/pea.py 91.72% <0.00%> (-0.72%) ⬇️
jina/peapods/gateway.py 95.03% <0.00%> (+0.70%) ⬆️
jina/peapods/grpc_asyncio.py 80.61% <0.00%> (+4.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed81dd3...8d72752. Read the comment docs.

Copy link
Member

@bwanglzu bwanglzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, through I don understand a word😅

@bwanglzu
Copy link
Member

Wait, CI failed

@JoanFM
Copy link
Member

JoanFM commented Nov 26, 2020

recheckcla

@github-actions
Copy link

Jina CLA check

❤️ Thank you for your pull request. It looks like this is your first contribution to an open source project maintained by Jina AI Limited. Before we can look at your pull request, we kindly ask that you sign our Contributor License Agreement. You can sign it by commenting in format below.


I have read the CLA Document and I hereby sign the CLA


@JoanFM
Copy link
Member

JoanFM commented Nov 26, 2020

Wait, CI failed

The test jinad is not working right now, no worries

@doomdabo
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA
Is it wrong for sign that sentence by commenting here?

@doomdabo
Copy link
Contributor Author

Wait, CI failed

The test jinad is not working right now, no worries

Thanks you

@doomdabo
Copy link
Contributor Author

hmm I think there are too much failing on checking..
Is it ok? So what I have to do now?
Thank you for helping us

@JoanFM
Copy link
Member

JoanFM commented Nov 26, 2020

Thank you very much for the contribution @doomdabo !!!!

@JoanFM
Copy link
Member

JoanFM commented Nov 26, 2020

@hanxiao needs to review as code owner!

@hanxiao hanxiao merged commit 086b21e into jina-ai:master Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/housekeeping This issue/PR is housekeeping size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants