fix: dont overwrite docker image names #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jina-bot
added
size/S
area/core
Codecov Report
@@ Coverage Diff @@
## master #1365 +/- ##
==========================================
+ Coverage 82.89% 83.02% +0.12%
==========================================
Files 103 103
Lines 6746 6826 +80
==========================================
+ Hits 5592 5667 +75
- Misses 1154 1159 +5
Continue to review full report at Codecov.
|
cristianmtr
force-pushed
the
fix-dont-overwrite-docker-images
branch
from
efe45e5
to
049fabf
Compare
hanxiao
approved these changes
Nov 30, 2020
nan-wang
reviewed
Dec 1, 2020
Comment on lines
+96
to
+98
| args = set_hub_build_parser().parse_args([os.path.join(cur_dir, 'hub-mwu'), '--push', '--host-info']) | ||
| summary = HubIO(args).build() | ||
| print(summary['is_build_success']) |
There was a problem hiding this comment.
An assertion for the exception is expected here.
There was a problem hiding this comment.
Is there a way to restore the PR and edit it? Or should I just create a new one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧
As part of the Hub Updater, we want to make sure NOT to overwrite images with the same name.